Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MicroProfile Health 4.0 Specification Review #104

Closed
21 of 22 tasks
xstefank opened this issue Nov 2, 2021 · 1 comment
Closed
21 of 22 tasks

MicroProfile Health 4.0 Specification Review #104

xstefank opened this issue Nov 2, 2021 · 1 comment
Labels
pmc-approved EF PMC has approved the lifecycle issue Release Review wg-approved MP WG has approved the lifecycle issue

Comments

@xstefank
Copy link

xstefank commented Nov 2, 2021

  • Specification name and version
  • Add the label Release Review
  • [ x Naming conventions for artifacts:
    • Specification PDF in the form of microprofile-project-spec-version.pdf
    • Specification HTML in the form of microprofile-project-spec-version.html
    • project is the microprofile specification short project name (config, health, ...)
    • version is the two digit x.y version of the specification

  • The Nexus Staging links (orgeclipsemicroprofile-NNNN where NNNN is the staging repository id) (eg, https://oss.sonatype.org/content/repositories/orgeclipsemicroprofile-NNNN/org/eclipse/microprofile/config/) which contain all the binaries and relevant documentation:

  • Summary that a Compatible Implementation is complete, passes the TCK, and that the TCK includes sufficient coverage of the specification.

@kwsutter
Copy link
Member

kwsutter commented Nov 9, 2021

Similar comment as #101 (comment)

The javadoc jar file contains the Apache license and the EFSL license, which are okay. But, it also contains the EF TCK license? That should not be part of the javadoc jar file. I don't think this update is a requirement for a respin, but the TCK license should be removed. Open an issue/pr to clean this up after the release.

On a similar vein, the TCK Javadoc jar file contains the EFSL, which doesn't seem right. I think this EFSL should be removed from the TCK Javadoc jar file. Just include this with the issue/pr you create for the previous comment.

Otherwise, looks good! Thanks!

@Emily-Jiang Emily-Jiang added pmc-approved EF PMC has approved the lifecycle issue wg-approved MP WG has approved the lifecycle issue labels Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pmc-approved EF PMC has approved the lifecycle issue Release Review wg-approved MP WG has approved the lifecycle issue
Projects
None yet
Development

No branches or pull requests

3 participants