Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MicroProfile Open Tracing 2.0 Specification Review #21

Closed
23 tasks done
xstefank opened this issue Dec 10, 2020 · 4 comments
Closed
23 tasks done

MicroProfile Open Tracing 2.0 Specification Review #21

xstefank opened this issue Dec 10, 2020 · 4 comments
Labels
ballot Release Review, Plan Review, Progress Review issue is now in ballot and should not be updated emo-approved EF EMO has approved the lifecycle issue final Release Review, Plan Review, Progress Review issue is ready for ballot in the eyes of the Spec team pmc-approved EF PMC has approved the lifecycle issue Release Review wg-approved MP WG has approved the lifecycle issue

Comments

@xstefank
Copy link

xstefank commented Dec 10, 2020

Specification issue template

When creating a specification project release review, create an issue in the MicroProfile-WG repository repo with the content defined as follows.

  • Specification name and version
  • Add the label Release Review
  • Naming conventions for artifacts:
    • Specification PDF in the form of microprofile-project-spec-version.pdf
    • Specification HTML in the form of microprofile-project-spec-version.html
    • project is the microprofile specification short project name (config, health, ...)
    • version is the two digit x.y version of the specification

  • The Nexus Staging links (orgeclipsemicroprofile-NNNN where NNNN is the staging repository id) (eg, https://oss.sonatype.org/content/repositories/orgeclipsemicroprofile-NNNN/org/eclipse/microprofile/config/) which contain all the binaries and relevant documentation:

@Emily-Jiang Emily-Jiang added ballot Release Review, Plan Review, Progress Review issue is now in ballot and should not be updated pmc-approved EF PMC has approved the lifecycle issue and removed pmc-approved EF PMC has approved the lifecycle issue labels Dec 10, 2020
@kwsutter
Copy link
Member

kwsutter commented Dec 16, 2020

The link for the staged apidocs is not working correctly: https://download.eclipse.org/microprofile/staging/microprofile-opentracing-2.0/apidocs/

It partially works where I get the three classes identified on the left hand side. But, the main page has displays a "Not Found" error page. I have verified that the javadoc jar seems to work just fine. It's just this staged directory that is not displaying correctly.

I also have a couple of comments on the CCR. Nothing major to prevent a +1, but these items should be cleaned up before declaring they are final.

@xstefank
Copy link
Author

The link for the staged apidocs is not working correctly: https://download.eclipse.org/microprofile/staging/microprofile-opentracing-2.0/apidocs/

It partially works where I get the three classes identified on the left hand side. But, the main page has displays a "Not Found" error page. I have verified that the javadoc jar seems to work just fine. It's just this staged directory that is not displaying correctly.

It works for me. No Not Founds. Not sure what can be the problem.

I also have a couple of comments on the CCR. Nothing major to prevent a +1, but these items should be cleaned up before declaring they are final.

CCR was updated according to the requierements.

@kwsutter
Copy link
Member

The link for the staged apidocs is not working correctly: https://download.eclipse.org/microprofile/staging/microprofile-opentracing-2.0/apidocs/
It partially works where I get the three classes identified on the left hand side. But, the main page has displays a "Not Found" error page. I have verified that the javadoc jar seems to work just fine. It's just this staged directory that is not displaying correctly.

It works for me. No Not Founds. Not sure what can be the problem.

Yeah. Thanks, @xstefank. As @radcortez pointed out, it might be a Firefox issue... Works fine on Chrome. Sorry for the fire drill, but thanks for checking it out.

I also have a couple of comments on the CCR. Nothing major to prevent a +1, but these items should be cleaned up before declaring they are final.

CCR was updated according to the requirements.

Thanks!

@Emily-Jiang
Copy link
Member

@dblevins @aeiras please cast your vote via the microprofile-wg! You can find the thread here.

@Emily-Jiang Emily-Jiang added emo-approved EF EMO has approved the lifecycle issue wg-approved MP WG has approved the lifecycle issue final Release Review, Plan Review, Progress Review issue is ready for ballot in the eyes of the Spec team labels Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ballot Release Review, Plan Review, Progress Review issue is now in ballot and should not be updated emo-approved EF EMO has approved the lifecycle issue final Release Review, Plan Review, Progress Review issue is ready for ballot in the eyes of the Spec team pmc-approved EF PMC has approved the lifecycle issue Release Review wg-approved MP WG has approved the lifecycle issue
Projects
None yet
Development

No branches or pull requests

3 participants