Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module directories lower case #79

Open
tomjaguarpaw opened this issue Sep 11, 2019 · 5 comments
Open

Module directories lower case #79

tomjaguarpaw opened this issue Sep 11, 2019 · 5 comments
Assignees

Comments

@tomjaguarpaw
Copy link
Collaborator

In the following documentation we see that module directory names must be lower case but the module binary name can be upper case. Is there a particular reason for changing the case? Does something go wrong if we choose it to be exactly the same as the module binary name?

https://github.com/awf/ADBench/blob/18dcb403aa50895a8700d69ea83253eab9079a39/docs/cpp/Modules.md#adding-new-modules

@novikov-alexander-zz
Copy link
Contributor

run-all script uses this convention to run modules in the current implementation.
But I don't see any obstacles to rename existing folders and change run-all script to meet your convention.

@tomjaguarpaw
Copy link
Collaborator Author

I think it would make life a simpler if there is no difference between the two. Let's leave this issue open for a bit in case anyone else knows a reason why we shouldn't change it.

@novikov-alexander-zz
Copy link
Contributor

I've discussed it with @msdmkats and we concluded that there are no any other special reasons. So, I will close this issue after I fix it.

@tomjaguarpaw
Copy link
Collaborator Author

OK, that will be great.

@novikov-alexander-zz
Copy link
Contributor

Sorry, I don't have time to finish it. So, it will be closed when someone else fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants