[ChangeRequest] page 253 "Sales Journal"

[RZ440]

Describe the request

Hello, can you please move the variables CurrentJnlBatchName, AccName and BalAccName to protected?

    var
        GeneralLedgerSetup: Record "General Ledger Setup";
        SalesReceivablesSetup: Record "Sales & Receivables Setup";
        GenJnlManagement: Codeunit GenJnlManagement;
        ClientTypeManagement: Codeunit "Client Type Management";
        JournalErrorsMgt: Codeunit "Journal Errors Mgt.";
        BackgroundErrorHandlingMgt: Codeunit "Background Error Handling Mgt.";
        ApprovalMgmt: Codeunit "Approvals Mgmt.";
        ChangeExchangeRate: Page "Change Exchange Rate";
        GenJnlBatchApprovalStatus: Text[20];
        GenJnlLineApprovalStatus: Text[20];
        Balance: Decimal;
        TotalBalance: Decimal;
        NumberOfRecords: Integer;
        ShowBalance: Boolean;
        ShowTotalBalance: Boolean;
        ApplyEntriesActionEnabled: Boolean;
        BalanceVisible: Boolean;
        TotalBalanceVisible: Boolean;
        IsPostingGroupEditable: Boolean;
        AmountVisible: Boolean;
        DebitCreditVisible: Boolean;
        BackgroundErrorCheck: Boolean;
        ShowAllLinesEnabled: Boolean;
        IsSaaSExcelAddinEnabled: Boolean;
        IsSimplePage: Boolean;
        DocumentAmount: Decimal;
        EmptyDocumentTypeErr: Label 'You must specify a document type for %1.', Comment = '%1 = Document number.';
        NegativeDocAmountErr: Label 'You must specify a positive amount as the document amount. If the journal line is for a document type that has a negative amount, the amount will be tracked correctly.';
        ActionOnlyAllowedForAllocationAccountsErr: Label 'This action is only available for lines that have Allocation Account set as Account Type or Balancing Account Type.';
        UseAllocationAccountNumber: Boolean;
        JobQueuesUsed: Boolean;
        JobQueueVisible: Boolean;
        VATDateEnabled: Boolean;
        OpenApprovalEntriesOnBatchOrAnyJnlLineExist: Boolean;
        ShowWorkflowStatusOnBatch: Boolean;
        ShowWorkflowStatusOnLine: Boolean;
        EnabledGenJnlLineWorkflowsExist: Boolean;
        EnabledGenJnlBatchWorkflowsExist: Boolean;
        CanRequestFlowApprovalForBatchAndAllLines: Boolean;
        OpenApprovalEntriesOnJnlBatchExist: Boolean;
        CanRequestFlowApprovalForBatch: Boolean;
        CanCancelApprovalForJnlBatch: Boolean;
        CanCancelFlowApprovalForBatch: Boolean;
        CanCancelApprovalForJnlLine: Boolean;
        CanCancelFlowApprovalForLine: Boolean;
        OpenApprovalEntriesOnJnlLineExist: Boolean;
        OpenApprovalEntriesExistForCurrUser: Boolean;
        ApprovalEntriesExistSentByCurrentUser: Boolean;
        OpenApprovalEntriesOnBatchOrCurrJnlLineExist: Boolean;
        CanRequestFlowApprovalForBatchAndCurrentLine: Boolean;

    protected var
        ShortcutDimCode: array[8] of Code[20];
        DimVisible1: Boolean;
        DimVisible2: Boolean;
        DimVisible3: Boolean;
        DimVisible4: Boolean;
        DimVisible5: Boolean;
        DimVisible6: Boolean;
        DimVisible7: Boolean;
        DimVisible8: Boolean;
        CurrentJnlBatchName: Code[10];
        AccName: Text[100];
        BalAccName: Text[100];

Additional context

The page variables CurrentJnlBatchName, AccName and BalAccName need to be visible to extension code to ensure data consistency. Duplicating those variables in extension code would bear the risk of losing track of changes to those variables.
Internal work item: AB#500338

[JesperSchulz]

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.

Build ID: 17192.