Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Full-width images with fixed height and correct fill/crop behavior #2291

Closed
andrewleader opened this issue Jan 11, 2019 · 1 comment
Labels
Projects

Comments

@andrewleader
Copy link
Contributor

Summary

Some authors want to display a full-width image, but with a fixed height. But they don't control the aspect ratio of the image, so they need to be able to specify the fill mode of the image, so that it fills the entire area. Note that this request is similar, but still distinct from the request for borderless bleeding images (#2290).

What they want

image

What they get today

Today, either they choose to not control the height and the image will expand to whatever height depending on the aspect ratio...

        {
            "type": "Image",
            "url": "https://picsum.photos/300/400?image=882",
            "size": "stretch"
        }

image

OR, if they choose to set the height, the image won't crop/fill the entire space.

        {
            "type": "Image",
            "url": "https://picsum.photos/300/400?image=882",
            "size": "stretch",
            "height": "100px"
        }

image

Asks

  • Outlook partners
@andrewleader
Copy link
Contributor Author

Shipped in 1.2!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants