Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPF Input.ChoiceSet incorrectly defaults to "expanded" #2446

Closed
andrewleader opened this issue Feb 21, 2019 · 2 comments · Fixed by #2765
Closed

WPF Input.ChoiceSet incorrectly defaults to "expanded" #2446

andrewleader opened this issue Feb 21, 2019 · 2 comments · Fixed by #2765

Comments

@andrewleader
Copy link
Contributor

andrewleader commented Feb 21, 2019

Platform

  • .NET WPF

Version of SDK

Latest master as of 2/21/2019 (so 1.2 feature set).

Also 1.1 behaved this way too (just cloned 1.1 branch and tried WPF Visualizer), so this is NOT a new regression

Also 1.0 behaved this way too... so since the very beginning it's been like this.

Issue

Input.ChoiceSet is supposed to default to "style": "compact". However, in the WPF visualizer, when style isn't specified, it's displayed as expanded...

Style: undefined

Expected

image

Actual

image

{
    "type": "AdaptiveCard",
    "body": [
        {
            "type": "TextBlock",
            "size": "Medium",
            "weight": "Bolder",
            "text": "\"style\": undefined"
        },
        {
            "type": "Input.ChoiceSet",
            "id": "myChoiceSet",
            "value": "Choice 1",
            "choices": [
                {
                    "title": "Choice 1",
                    "value": "Choice 1"
                },
                {
                    "title": "Choice 2",
                    "value": "Choice 2"
                }
            ]
        }
    ],
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.0"
}
@shalinijoshi19
Copy link
Member

Ideally this should be fixed; @paulcam206 FYI; if we run through existing 1.2 bugs we tackle this next. Should include documentation as well as part of the fix.

@microsoft microsoft deleted a comment Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants