Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP] Inconsistent warning about inlines type #2855

Closed
paulcam206 opened this issue May 3, 2019 · 2 comments · Fixed by #3075
Closed

[UWP] Inconsistent warning about inlines type #2855

paulcam206 opened this issue May 3, 2019 · 2 comments · Fixed by #3075
Assignees
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug Platform-XAML Bugs or features related to Xaml Renderer
Projects
Milestone

Comments

@paulcam206
Copy link
Member

paulcam206 commented May 3, 2019

In UWP, this card is an error:

{
	"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
	"type": "AdaptiveCard",
	"version": "1.2",
	"body": [
		{
			"type": "RichTextBlock",
			"inlines": ""
		}
	]
}

however, this card is considered fine (note value of inlines):

{
	"$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
	"type": "AdaptiveCard",
	"version": "1.2",
	"body": [
		{
			"type": "RichTextBlock",
			"inlines": {}
		}
	]
}

Both cards are incorrect, as inlines has to be an array type.

Note that JS incorrectly allows both of these payloads (and even doesn't require "inlines", although note that JS also doesn't require "text" on TextBlock, so that's related to a whole separate issue)

@paulcam206 paulcam206 added Bug Platform-XAML Bugs or features related to Xaml Renderer BugBash labels May 3, 2019
@shalinijoshi19
Copy link
Member

Good to have; Looks like an easy fix if we can absorb it; @RebeccaAnne do we have clarity around addressing this?

@shalinijoshi19
Copy link
Member

Moving it out of 1.2 given there are still pending

@shalinijoshi19 shalinijoshi19 added this to Needs triage in Bug Triage via automation May 13, 2019
@shalinijoshi19 shalinijoshi19 added this to the Backlog milestone May 19, 2019
@shalinijoshi19 shalinijoshi19 moved this from Needs triage to Backlog in Bug Triage May 19, 2019
@shalinijoshi19 shalinijoshi19 moved this from Backlog to Approved (current release) in Bug Triage Jun 3, 2019
@andrewleader andrewleader added Area-Inconsistency Bugs around renderer inconsistencies across different platforms Potential-1.2.1 labels Jun 12, 2019
@RebeccaAnne RebeccaAnne moved this from Approved to In Progress in Bug Triage Jun 17, 2019
@RebeccaAnne RebeccaAnne moved this from In Progress to In Code Review in Bug Triage Jun 17, 2019
Bug Triage automation moved this from In Code Review to Closed Jun 24, 2019
@shalinijoshi19 shalinijoshi19 modified the milestones: Backlog, 1.2.1 Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug Platform-XAML Bugs or features related to Xaml Renderer
Projects
No open projects
Bug Triage
  
Closed
Development

Successfully merging a pull request may close this issue.

4 participants