Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shared model] BaseInputElement is serializing isRequired property #3072

Closed
almedina-ms opened this issue Jun 17, 2019 · 3 comments · Fixed by #3131
Closed

[Shared model] BaseInputElement is serializing isRequired property #3072

almedina-ms opened this issue Jun 17, 2019 · 3 comments · Fixed by #3131
Assignees
@almedina-ms
Labels
Bug Platform-Shared Model
Projects
Bug Triage
Milestone
1.2.1

Comments

@almedina-ms
Copy link
Contributor

Platform

Impacts:

  • Android
  • iOS
  • UWP

Version of SDK

1.2

Issue

isRequired was not shipped as part of v1.2 so serializing it is a bug in it's own
@shalinijoshi19
Copy link
Member

@almedina-ms was this fixed as part of your PR here #3100 or does this need to be fixed still?

@ghost ghost added the Triage-Needed label Jul 1, 2019
@ghost ghost added this to Needs triage in Bug Triage Jul 1, 2019
@ghost ghost moved this from Needs triage to Approved in Bug Triage Jul 1, 2019
@ghost ghost removed the Triage-Needed label Jul 1, 2019
@shalinijoshi19 shalinijoshi19 added this to the 1.2.1 milestone Jul 1, 2019
@RebeccaAnne
Copy link
Contributor

This has existed since 1.0, when we thought we might have an IsRequired property and it never got pulled.

@almedina-ms
Copy link
Contributor Author

There are UWP methods for setting the isRequired property but we never use the property, we just serialize it, I was thinking of removing just the serialization for the method just so there are no breaking changes, is that good??

@almedina-ms almedina-ms mentioned this issue Jul 1, 2019
Merged
@almedina-ms almedina-ms moved this from Approved to In Code Review in Bug Triage Jul 1, 2019
@shalinijoshi19 shalinijoshi19 modified the milestone: 1.2.1 Jul 5, 2019
Bug Triage automation moved this from In Code Review to Closed Jul 12, 2019
@ghost ghost moved this from Closed to In Code Review in Bug Triage Jul 13, 2019
@shalinijoshi19 shalinijoshi19 moved this from In Code Review to Documentation in Bug Triage Jul 16, 2019
@shalinijoshi19 shalinijoshi19 moved this from Documentation to Closed in Bug Triage Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@almedina-ms almedina-ms

Labels
Bug Platform-Shared Model
Projects
No open projects
Bug Triage
  
Closed
Milestone
1.2.1
Development

Successfully merging a pull request may close this issue.

[Shared] Remove isRequired property serialization microsoft/AdaptiveCards
3 participants
@RebeccaAnne @shalinijoshi19 @almedina-ms