Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input validation & Labels Support #3081

Closed
19 of 21 tasks
productboard-ac opened this issue Jun 18, 2019 · 10 comments · Fixed by #4005, #4197, #4039, #4088 or #4190
Closed
19 of 21 tasks

Input validation & Labels Support #3081

productboard-ac opened this issue Jun 18, 2019 · 10 comments · Fixed by #4005, #4197, #4039, #4088 or #4190

Comments

@productboard-ac
Copy link
Collaborator

productboard-ac commented Jun 18, 2019

Summary

Authors need input validation, both just simple "isRequired" and more advanced than just saying that an input is required.

ValidateOnSubmit

Dev Task List Breakdown

Input Labels Support

  • JS implementation | 10 days
  • C++ Object Model | 4 days
  • UWP Implementation | 4 days
  • Android Implementation | 4 days
  • iOS Implementation | 4 days
  • C# Object Model | 4 days
  • .NET implementation | 4 days
  • HTML implementation | 4 days
  • Bug Bash | 2 days
  • Update Documentation | 2 days
  • Merge from topic branch into master] | 2 days

Input Validation Support

  • JS implementation | 5 days
  • C++ Object Model | 6 days
  • UWP Implementation | 5 days
  • Android Implementation | 5 days
  • iOS Implementation | 5 days
  • C# Object Model | 5 days
  • .NET implementation | 5 days
  • HTML implementation | 6 days
  • Bug Bash | 7 days
  • Update Documentation | 6 days

Feature Spec including prioritized feature list & proposed schema changes

https://docs.microsoft.com/en-us/adaptive-cards/authoring-cards/input-validation

@productboard-ac
Copy link
Collaborator Author

@dclaux
Copy link
Member

dclaux commented Jul 8, 2019

My suggestions:

  • inputNecessityIndicators (why is this an enum?) --> showRequiredInputIndicators: true|false
  • showInputValidationErrors: this needs to be introduced as well as a way for a host to custom render these error messages. We've had a very long debate around this.
  • displayInputSuccessIndicators: don't implement this feature. There is at best anecdotal evidence that we need it
  • errorMessage --> validationErrorMessage

@andrewleader
Copy link
Contributor

andrewleader commented Jul 12, 2019

7/12/2019

  • More spec details needed on behavior of ShowCard and which inputs it validates on
  • showInputValidationErrors for renderers (via code) makes sense
  • Not sure whether we should have success indicators

Proposal approved

@shalinijoshi19
Copy link
Member

Assigning to you @RebeccaAnne since you are driving this feature. thanks

@ghost
Copy link

ghost commented Dec 6, 2019

This issue has been automatically marked as stale because it has not had any activity for 5 days.

@KoradaRajesh
Copy link

{
"type": "AdaptiveCard",
"version": "1.0",
"body": [
{
"type": "Container",
"items": [
{
"type": "TextBlock",
"text": "New TextBlock"
}
]
},
{
"type": "Container",
"items": [
{
"type": "Input.Text",
"placeholder": "Placeholder text",
"id": "Test",
"validation":{
"necessity":"required",
"errorMessage":"New TextBlock is Required"
}
}
]
},
{
"type": "Container",
"items": [
{
"type": "ActionSet",
"actions": [
{
"type": "Action.Submit",
"title": "Action.Submit"
}
]
}
]
}
],
"$schema": "http://adaptivecards.io/schemas/adaptive-card.json"
}

@bodyzatva
Copy link

Can anyone tell me if this feature is available ?

@Zenulous
Copy link

Zenulous commented Apr 1, 2020

This is still slated for the 1.3 milestone. In any case it is currently not available.

@nikoma
Copy link

nikoma commented Apr 21, 2020

That would be great!

@shalinijoshi19 shalinijoshi19 added this to To Do - v1 (Target release July) in Input Evolution for vNext May 12, 2020
@shalinijoshi19 shalinijoshi19 moved this from To Do - v1 (Target release July) to To do: Milestone: "20.05" in Input Evolution for vNext May 12, 2020
@shalinijoshi19 shalinijoshi19 changed the title Input validation Input validation & Labels Support May 12, 2020
@microsoft microsoft deleted a comment Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment