Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS][Custom Actions] Support custom action parsing for selectAction #3519

Closed
tnev opened this issue Oct 11, 2019 · 3 comments · Fixed by #3526
Closed

[iOS][Custom Actions] Support custom action parsing for selectAction #3519

tnev opened this issue Oct 11, 2019 · 3 comments · Fixed by #3526
Assignees
Projects

Comments

@tnev
Copy link

tnev commented Oct 11, 2019

Platform

  • iOS

Author or host

host

Version of SDK

1.2.1

Details

It doesn't currently seem possible to use custom actions for a Container's selectAction. It looks like selectAction uses ParseContext's actionParserRegistration to look for action parsers corresponding to the action type, unlike the ACRCustomActionRenderer, which will call ACRRegistration. I'm not sure how we could override the selectAction parsing unless it used ACRRegistration as some point. Could you confirm this, or let me know if there's an alternative for what I'm trying to accomplish? Thank you.

@tnev tnev added the Bug label Oct 11, 2019
@ghost ghost added the Triage-Needed label Oct 11, 2019
@ghost ghost added this to Needs triage in Bug Triage Oct 11, 2019
@ghost ghost moved this from Needs triage to Investigate in Bug Triage Oct 11, 2019
@ghost ghost removed the Triage-Needed label Oct 11, 2019
@shalinijoshi19
Copy link
Member

@nesalang thoughts ?

@jwoo-msft jwoo-msft moved this from Investigate to In Progress in Bug Triage Oct 11, 2019
@jwoo-msft
Copy link
Member

jwoo-msft commented Oct 17, 2019

@tnev @shalinijoshi19
Hello,
we can add this feature to iOS. And I could share a branch that has this feature if you are blocked, but I have to check to see if this feature is supported on all other platforms, and make sure the way we support is consistent across the platforms, so complete solution may come later, but the release of iOS solution won't be depended on implementation of other platforms just designs unless our team wants to time the releases as well. because of that reason, the change I share with you may change.

@ghost
Copy link

ghost commented Nov 5, 2019

🎉This issue was addressed in #, which has now been successfully released as AdaptiveCards@v1.2.4.:tada:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Bug Triage
  
Closed
3 participants