Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][Button Icon Rendering] [Button icons placed on the left of the title are pushed out of the button, icon size not honored] #3543

Closed
shbhadra opened this issue Oct 29, 2019 · 6 comments · Fixed by #3547
Assignees
Labels
Bug Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Platform-Android
Projects

Comments

@shbhadra
Copy link

Platform

What platform is your issue or question related to? (Delete other platforms).

  • Android

Author or host

Host

Version of SDK

1.2.0

Details

  • Upon configuring the HostConfig to place the button icons to the left of the button title, the icons are pushed out of the bounds of the button.

  • Icon size for the button icon as mentioned in the HostConfig is not honoured.

button_icon

Note the following observations :

  • For the case that there is only a single button the icon is infact rendered within the bounds of the button.

  • For the case of multiple buttons, only the icon in the last button is rendered within the bounds of the button.

  • The size of the icon is always rendered at the very small size as shown in the screenshot above irrespective of the value defined in the host config json.

Expecting the result to be similar to what is rendered on web, as shown in the image below
desktop_btns

Please find the following in the attached zip

  1. Json for the card shown in the screenshot
  2. HostConfig used for the card in the screenshot.
  3. The screenshot itself.

button_icon_render_issue.zip

@shbhadra shbhadra added the Bug label Oct 29, 2019
@ghost ghost added the Triage-Needed label Oct 29, 2019
@ghost ghost added this to Needs triage in Bug Triage Oct 29, 2019
@shalinijoshi19 shalinijoshi19 added the Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner label Oct 29, 2019
@shalinijoshi19
Copy link
Member

@almedina-ms can you please take a look at this with high priority? It's blocking Teams mobile upgrade to 1.2* ; @matthidinger FYI

@ghost ghost moved this from Needs triage to Investigate in Bug Triage Oct 29, 2019
@ghost ghost removed the Triage-Needed label Oct 29, 2019
@almedina-ms
Copy link
Contributor

For the image size that's by design, only if the icon is on top of the action test then we honour the iconSize property, otherwise it must match the size of the text next to it. Looking at the icons being pushed out of the button

@VikrantSingh01
Copy link

Needed for Teams Mobile Platform

@ghost ghost moved this from Investigate to In Code Review in Bug Triage Oct 30, 2019
@shbhadra
Copy link
Author

@almedina-ms For the screenshot in the above description, the icon size is smaller than the text size too, and the icon size in the hostConfig is set to be very large and is thus not smaller than text size because of a host configuration.

@shalinijoshi19 shalinijoshi19 added Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Triage-Approved for Fix and removed Triage-Investigate labels Nov 11, 2019
@shalinijoshi19
Copy link
Member

@almedina-ms please take a look at @shbhadra 's comment above around iconsize ? thanks

@ghost
Copy link

ghost commented Nov 27, 2019

🎉AdaptiveCards@v1.2.5 has been released which fixes this issue.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Platform-Android
Projects
No open projects
Bug Triage
  
Closed
Development

Successfully merging a pull request may close this issue.

4 participants