Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android][Element Rendering] [Spacing within Choice sets not rendered] #3554

Closed
shbhadra opened this issue Oct 31, 2019 · 4 comments · Fixed by #3594
Closed

[Android][Element Rendering] [Spacing within Choice sets not rendered] #3554

shbhadra opened this issue Oct 31, 2019 · 4 comments · Fixed by #3594
Assignees
@almedina-ms
Labels
Bug Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Platform-Android
Projects
Bug Triage

Comments

@shbhadra
Copy link

shbhadra commented Oct 31, 2019 •
edited by jwoo-msft

this needs to be fixed for radio button as well

Platform

  • Android

Author or host

Host

Version of SDK

1.2.0

Details

There is no spacing between the elements in a choice set, for an "expanded" style of the choice set, for both checkboxes and radio buttons. The issue is illustrated in the image below
choice_without_wrap
However upon setting "wrap" : true, the spacing shows up
choice_with_wrap
The attached zip contains the card jsons and screenshots
choice_set_spacing.zip
@shbhadra shbhadra added the Bug label Oct 31, 2019
@ghost ghost added the Triage-Needed label Oct 31, 2019
@ghost ghost added this to Needs triage in Bug Triage Oct 31, 2019
@shalinijoshi19 shalinijoshi19 added the Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner label Nov 4, 2019
@shalinijoshi19
Copy link
Member

@almedina-ms can you help pick this up for the November release as part of the Teams blocker bugs? Thanks

@ghost ghost moved this from Needs triage to Investigate in Bug Triage Nov 4, 2019
@ghost ghost removed the Triage-Needed label Nov 4, 2019
@shalinijoshi19 shalinijoshi19 added Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Platform-Android AdaptiveCards v1.2.5 labels Nov 11, 2019
@almedina-ms almedina-ms mentioned this issue Nov 12, 2019
Merged
@ghost ghost moved this from Investigate to In Code Review in Bug Triage Nov 12, 2019
Bug Triage automation moved this from In Code Review to Closed Nov 18, 2019
@almedina-ms almedina-ms mentioned this issue Nov 19, 2019
Merged
@ghost
Copy link

ghost commented Nov 27, 2019

🎉AdaptiveCards@v1.2.5 has been released which fixes this issue.:tada:

Handy links:

@jwoo-msft jwoo-msft reopened this Jan 7, 2020
@jwoo-msft
Copy link
Member

@shalinijoshi19

Teams confirmed that the issue is fixed from the last meeting; however, they said single select ChoiceSet that uses radio button still has the issue; and reason for the re-opening the issue.

@VikrantSingh01
Copy link

@shbhadra : Let's log a new bug for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@almedina-ms almedina-ms

Labels
Bug Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Platform-Android
Projects
No open projects
Bug Triage
  
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Android] Fix spacing in ChoiceSets with wrappjng microsoft/AdaptiveCards
5 participants
@jwoo-msft @shalinijoshi19 @almedina-ms @shbhadra @VikrantSingh01