Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][Inconsistency with web and iOS] [Invalid value for column width not defaulting to auto in Android] #3864

Closed
shbhadra opened this issue Mar 23, 2020 · 3 comments · Fixed by #3868
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android)
Milestone

Comments

@shbhadra
Copy link

Platform

What platform is your issue or question related to? (Delete other platforms).

  • Android

Author or host

HOST

Version of SDK

1.2.6

Details

Consider the following json
{ "type":"AdaptiveCard", "version":"1.2", "$schema":"http://adaptivecards.io/schemas/adaptive-card.json", "body":[ { "type":"ColumnSet", "spacing":"none", "columns":[ { "type":"Column", "items":[ { "type":"Image", "url":"https://www.sewausa.org/resources/Sewa%20USA%20Images/DIY%20Campaigns/profile-clipart-generic-user-12.png", "horizontalAlignment":"left", "size":"small", "style":"person" } ], "horizontalAlignment":"left", "width":"automatic", "verticalContentAlignment":"center", "separator":false }, { "type":"Column", "verticalContentAlignment":"center", "items":[ { "type":"TextBlock", "text":"Some text here", "weight":"Bolder" }, { "type":"TextBlock", "text":" " } ] }, { "type":"Column", "verticalContentAlignment":"center", "items":[ { "type":"ActionSet", "actions":[ { "type":"Action.Submit", "title":"Button description", "data":{ "nwCommand":"ANYTIME_FEEDBACK_RECIPIENT_SELECTION", "wid":"2a37f8012406102d1ad61154601e02a1", "descriptor":"Logan Johnson" } } ] } ] } ] } ] }

Which defines the column width for one of the columns as "automatic". While this is not a valid value for the width parameter, the card renders fine on iOS and Web, however it doesn't render on android.

As rendered on iOS
image

As rendered on Web
image

The web visualizer shows the message - Invalid column width:automatic - defaulting to "auto"

However android doesn't render the card at all.

@shbhadra shbhadra added the Bug label Mar 23, 2020
@ghost ghost added the Triage-Needed label Mar 23, 2020
@ghost ghost added this to Needs triage in Bug Triage Mar 23, 2020
@VikrantSingh01 VikrantSingh01 added Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android) Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner labels Mar 23, 2020
@VikrantSingh01 VikrantSingh01 added the Area-Inconsistency Bugs around renderer inconsistencies across different platforms label Mar 24, 2020
@ghost ghost moved this from Needs triage to In Code Review in Bug Triage Mar 24, 2020
@shalinijoshi19
Copy link
Member

@jwoo-msft / @almedina-ms This wasnt shipped as part of AdaptiveCards 1.2.8 - what's the current status on this?

@VikrantSingh01
Copy link

@jwoo-msft / @Shalini-MSFT : Pls. get this prioritised.

Bug Triage automation moved this from In Code Review to Closed May 28, 2020
Inconsistencies Proposal for vNext automation moved this from To do to Done May 28, 2020
@ghost
Copy link

ghost commented Jun 1, 2020

🎉AdaptiveCards@v1.2.9 has been released which fixes this issue.:tada:

Handy links:

@shalinijoshi19 shalinijoshi19 added this to the 20.05 milestone Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Inconsistency Bugs around renderer inconsistencies across different platforms Bug High Priority Partner-MsftTeams Issues related to AC integration with Microsoft Teams partner Partner-MsftTeamsMobile Bugs related specifically to Teams Mobile integration (iOS/Android)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants