[JavaScript][Deregistering a property from the parser/render]

[mokandre]

What platform is your feature request related to?

• JavaScript

Is your feature request related to a problem? Please describe.

We would like to disable the functionality of unsupported properties on parser/render

Describe the solution you'd like
It would be great to have a way to Deregister a property from the parser/render

Deregister has to work for the following cases:

• Deregister the property for a particular element( For Example: Deregister the Height property of columnSet)
• Deregister the property for all elements(For Example: Deregister the verticalContentAlignment property for all the elements where it supports)

For Example

Unsupported Property : maxLines for TextBlock element.

After deregistering a property, though users try to add maxLines property to their JSON then that property shouldn't render/parse.

Current behavior:

If possible, validator have to point out that the unsupported properties are not supported as warning message

For Example:(Warning Message)

Unknown/Unsupported property :maxLines of TextBlock Element

[dclaux]

@mokandre This is actually already supported, via the SrializableObject.onRegisterCustomProperties event. Example:

Adaptive.SerializableObject.onRegisterCustomProperties = (sender: Adaptive.SerializableObject, schema: Adaptive.SerializableObjectSchema) => {
    if (sender instanceof Adaptive.TextBlock) {
        schema.remove(Adaptive.TextBlock.heightProperty);
    }
}

Can you please try this and close this issue if that solves your problem?

[mokandre]

@mokandre This is actually already supported, via the SrializableObject.onRegisterCustomProperties event. Example:

Adaptive.SerializableObject.onRegisterCustomProperties = (sender: Adaptive.SerializableObject, schema: Adaptive.SerializableObjectSchema) => {
    if (sender instanceof Adaptive.TextBlock) {
        schema.remove(Adaptive.TextBlock.heightProperty);
    }
}

Can you please try this and close this issue if that solves your problem?

@dclaux Able to deregister some of the properties but
Following are some issues facing while deregistering (fallback and requires) properties

• Deregistering requires property:

Output:

• I'm not able to access the fallback property in element (Example: Adaptive.TextBlock. ? ). Can you give me an example of how to deregister fallback property for all elements?

[dclaux]

@mokandre I will implement another model for property deregistration. I could just fix the bug you mentioned, but I fear there will be more such bugs as the renderer expects and needs some properties to be registered.

As for fallback, it is not handled as a property internally and therefore cannot be unregistered. Fallback is mainly a parse-time feature, and fallback elements are not parsed if they are not needed. I will add a global flag to disable fallback.

[ghost]

🎉AdaptiveCards@2020.07 has been released which fixes this issue.:tada:

Handy links:

• Release Notes
• AdaptiveCards Website
• Official NPM Designer Release
• Official NPM Templating Release
• Official NPM Renderer Release
• Official Nuget Templating Release
• Official Nuget Renderer Release
• Official Maven Renderer Release
• Official CocoaPod Renderer Release