Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Schema][HostConfig] Host Config schema needs to be updated to reflect 1.3 changes #4580

Closed
2 tasks done
RebeccaAnne opened this issue Aug 12, 2020 · 3 comments
Closed
2 tasks done
Assignees
Labels
Projects
Milestone

Comments

@RebeccaAnne
Copy link
Contributor

RebeccaAnne commented Aug 12, 2020

Details

Although the Adaptive Cards schema has been updated to reflect the new Input Validation changes, the HostConfig schema has not. We need to add the inputs functionality to the schema (host-config.json) and also update the corresponding docs page (https://docs.microsoft.com/en-us/adaptive-cards/rendering-cards/host-config).

@ghost
Copy link

ghost commented Aug 13, 2020

Hi @RebeccaAnne. We have acknowledged this issue report. Please continue to follow this issue for updates/progress/questions.

@RebeccaAnne
Copy link
Contributor Author

For the documentation, it looks like the documentation was updated manually in MicrosoftDocs/AdaptiveCards#322. We have a tool to generate those docs, but that tool only generates the first layer of the schema, not sublayers. In this case, the manual documentation documents all relevant objects (InputsConfig, LabelConfig, InputLabelConfig, and ErrorMessageConfig), whereas the generated schema only would document the top layer (InputsConfig). Because of this, I am not going to update the docs using the tool. Logged #4698 to track improving the tool to be able to generate those docs for us.

@RebeccaAnne RebeccaAnne moved this from Approved to In Code Review in Bug Triage Aug 28, 2020
Bug Triage automation moved this from In Code Review to Closed Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Bug Triage
  
Closed
Development

No branches or pull requests

2 participants