Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Freeway-Bug}[Adaptive Cards: Main Body]: Ensures that lists are structured correctly under 'Made For'. #8154

Closed
vagpt opened this issue Dec 19, 2022 · 3 comments · Fixed by #8270
Labels
A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yTTValidated A11yWCAG Accessibility issue that affects compliance Area-Accessibility Bugs around feature accessibility Area-Renderers Bug HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization HCL-E+D
Projects

Comments

@vagpt
Copy link
Collaborator

vagpt commented Dec 19, 2022

Target Platforms

Other

SDK Version

1,5

Application Name

Adaptive Cards

Problem Description

Test Environment:
URL: https://adaptivecards.io
OS Version: 22H2(OS Build 25247.1000)
Browser Version: Version 110.0.1543.0 (Official build) dev (64-bit)
Tool: Accessibility Insight For Web

Repro Steps:

  1. Open the above URL in the browser.
  2. Run the accessibility insight for web tool and observe the issue.

Actual Result:
Lists are not structured correctly under 'Made For label'.
Expected Result:
List should structured correctly under 'Made For' label.

User Impact:
It will impact the screen reader user if the list is not structured correctly on the web page.

How to fix:
Fix any of the following:

  1. List element has direct children that are not allowed inside
  2. elements.

MAS Reference link:
https://microsoft.sharepoint.com/:w:/s/accessibility/EXdDUZzldv5MgwDaMHnTzcMBcT8opKGncYjU-gCJ4uqQdg?e=9nuVmt

“Have feedback to share on Bugs? Please help fill Trusted Tester Bug Feedback (office.com)

Screenshots

MAS1 3 1-Ensure lists are structured correctly
mas1 3 1-lists are not structured correctly

Card JSON

NA

Sample Code Language

No response

Sample Code

No response

@vagpt vagpt added Bug Area-Renderers Area-Accessibility Bugs around feature accessibility A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yWCAG Accessibility issue that affects compliance HCL-E+D HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization labels Dec 19, 2022
@ghost ghost added this to Not Triaged in Triage Dec 19, 2022
@vagpt vagpt changed the title [Adaptive Cards: Header Control]: Ensures that lists are structured correctly under 'Made For'. [Adaptive Cards: Main Body]: Ensures that lists are structured correctly under 'Made For'. Dec 19, 2022
@vagpt vagpt changed the title [Adaptive Cards: Main Body]: Ensures that lists are structured correctly under 'Made For'. {Freeway-Bug}[Adaptive Cards: Main Body]: Ensures that lists are structured correctly under 'Made For'. Jan 13, 2023
Triage automation moved this from Not Triaged to Closed Feb 3, 2023
@vagpt
Copy link
Collaborator Author

vagpt commented Mar 7, 2023

Hi @anna-dingler, This issue is still repro on the environment below, hence reactivating this issue.

Test Environment:
URL: https://adaptivecards.io/
OS Version: 22H2(OS Build 25247.1000)
Browser Version: Version 111.0.1660.14 (Official build) dev (64-bit)
Tool: Accessibility Insight For Web

Screenshot:

image

@vagpt vagpt reopened this Mar 7, 2023
Triage automation moved this from Closed to Not Triaged Mar 7, 2023
@anna-dingler
Copy link
Contributor

This issue has been fixed (verified on our test site) and will be included in our next release. I am closing this issue for now. Once a new version is available, if the issue persists please open a new issue to track.

Triage automation moved this from Not Triaged to Closed Mar 7, 2023
@vagpt
Copy link
Collaborator Author

vagpt commented Apr 27, 2023

This issue is working fine on the environment below, hence closing this issue.

Test Environment:
URL: https://adaptivecards.io/
OS Version: 22H2(OS Build 25330.1000)
Browser Version: 114.0.1807.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11ySev2 Accessibility issue with severity 2. This may impact the accessibility score A11yTTValidated A11yWCAG Accessibility issue that affects compliance Area-Accessibility Bugs around feature accessibility Area-Renderers Bug HCL-AdaptiveCards-Web Used by accessibility team for scorecard categorization HCL-E+D
Projects
Triage
Closed
Development

Successfully merging a pull request may close this issue.

2 participants