Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Switch to https://github.com/gofrs/uuid #27

Closed
adrianliechti opened this issue Mar 14, 2019 · 5 comments
Closed

Suggestion: Switch to https://github.com/gofrs/uuid #27

adrianliechti opened this issue Mar 14, 2019 · 5 comments

Comments

@adrianliechti
Copy link

you might want to switch your UUID library

see
https://github.com/gofrs/uuid
satori/go.uuid#75

your friends at the AKS engine did as well
Azure/aks-engine#466

cheers

@tandr
Copy link

tandr commented Mar 21, 2019

We have switched to github.com/google/uuid https://github.com/google/uuid seems to be maintained, but I am not sure if Microsoft is allowed to use Google's code.

@jjjordanmsft
Copy link
Contributor

iirc, google/uuid was marked unstable back when satori/go.uuid broke everything so I hesitated to move then. There's nothing preventing me from referencing either as long as they're BSD-licensed. We are using the Go standard library, after all.

I'll also have a look at gofrs. It's probably the most straightforward option. I think I want to keep the hacky uuid.go stuff because it's used in some contexts that are not really situated to handle errors.

@tandr
Copy link

tandr commented Mar 29, 2019

To think of it... How about having a hook (register a function) that allows users to specify func() string that returns uuid ? This way everybody will use the one that is already used in the app. The mechanism could be similar to what sql package uses for registration
Why the heck uuid generation is not a part of standard library is beyond me...

@kwontae
Copy link
Contributor

kwontae commented Oct 2, 2020

So why was this closed without switching to https://github.com/gofrs/uuid? This is a forked but maintained repo unlike the satori repo. Still being flagged for WS-2018-0594

@kwontae
Copy link
Contributor

kwontae commented Oct 2, 2020

@adrianliechti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants