Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] correlationHeaderExcludePatterns missing from types #1363

Closed
southpolesteve opened this issue Sep 4, 2020 · 5 comments
Closed

[BUG] correlationHeaderExcludePatterns missing from types #1363

southpolesteve opened this issue Sep 4, 2020 · 5 comments
Assignees
Labels
Milestone

Comments

@southpolesteve
Copy link

I see correlationHeaderExludePatterns was recently introduced, but it does not appear to be showing up in the types. In vscode, I get red squiggly lines when trying to use it:

image

  • OS/Browser: Chrome
  • SDK Version [e.g. 22]: 2.5.8
  • How you initialized the SDK:
const appInsights = new ApplicationInsights({
  config: {
    instrumentationKey: "foo",
    disableFetchTracking: false,
    enableCorsCorrelation: true,
    correlationHeaderExludePatterns : [/foo/]
  }
});
appInsights.loadAppInsights();
@kryalama kryalama self-assigned this Sep 4, 2020
@MSNev
Copy link
Collaborator

MSNev commented Sep 4, 2020

This is a type
correlationHeaderExludePatterns should be correlationHeaderExcludePatterns

Where did you get the "correlationHeaderExludePatterns" from -- searching the current repo the correct name "correlationHeaderExcludePatterns" is used

@kryalama kryalama added bug investigating Investigating the issue labels Sep 4, 2020
@southpolesteve
Copy link
Author

Doh 🤦 That is a typo. But I still see the same problem after correcting:

image

@southpolesteve southpolesteve changed the title [BUG] correlationHeaderExludePatterns missing from types [BUG] correlationHeaderExcludePatterns missing from types Sep 4, 2020
@MSNev
Copy link
Collaborator

MSNev commented Sep 4, 2020

Yep, we only defined it on the extension config doh! * 2, @kryalama is going to add it to the main IConfig as well which will resolve the issue -- will be included in the next release (scheduled for end of the month).

@kryalama kryalama added fixed - waiting release PR Committed and waiting deployment and removed investigating Investigating the issue labels Sep 4, 2020
@MSNev MSNev added this to the 2.5.9 milestone Sep 30, 2020
@MSNev
Copy link
Collaborator

MSNev commented Oct 12, 2020

Closing as 2.5.9 is now completely deployed to NPM and all CDN endpoints

@MSNev MSNev closed this as completed Oct 12, 2020
@MSNev MSNev removed the fixed - waiting release PR Committed and waiting deployment label Oct 12, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants