Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP calls via feign clients are not reported as dependencies #635

Closed
tomaszglinski opened this issue Apr 4, 2018 · 4 comments
Closed
Assignees
Labels

Comments

@tomaszglinski
Copy link

I tested both spring feign client as well as direct RestTemplate call, the latter is correctly reported as dependency, feign - not...

Do you have any hints how to enable it?

@tomaszglinski tomaszglinski changed the title HTTP calls via spring feign clients are not reported as dependencies HTTP calls via feign clients are not reported as dependencies Apr 4, 2018
@dhaval24
Copy link
Contributor

dhaval24 commented Apr 4, 2018

@tomaszglinski you are experience correct behavior. The dependency collection of rest clients namely SpringRestTemplate and SpringBoot Feign Client depends on the underlying HTTP Library being used. Our current instrumentation instruments ApacheHttpClient. Therefore if the clients use ApacheHttpClient then it should work out. I would recommend using ApacheHttpClient 4.5.3 version if possible.

@dhaval24 dhaval24 self-assigned this Apr 4, 2018
@tomaszglinski
Copy link
Author

Hi @dhaval24, as you saw in #637 I tried with ApacheHttpClient :)
I agree with your clarification. But I am wondering whether it would not be possible to add a great feature for feign (and feign-like) libs, meaning:
Application call feign using the business name of the called service, for example "users". Under the hood, the calls to "users" mean loadbalanced/retried/circuitbreaked calls to 3 instances of "users" service.
It would be great to see on the map, that my application calls "users" as an aggregated box, and the "users" box depends on 3 instances. Just like the SQL boxes on this image:

image

@grlima
Copy link
Contributor

grlima commented Apr 9, 2018

Dupe of #637

@grlima grlima closed this as completed Apr 9, 2018
@grava
Copy link

grava commented Mar 12, 2020

Hi, I am trying with no luck to configure my spring boot app to use FeignClient to use OkHttp or Apache Http Client and send data to AppInsights. Can someone point me to a complete configuration to aaccomplish the above ?
I tried with the application.yaml config using
feign:
okhttp:
enabled:true

but I cannot see any dependency in my AppInsights application map.

thanks !

@ghost ghost locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants