Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into Enhance the user settings #162

Open
xiaomi7732 opened this issue Mar 9, 2022 · 3 comments
Open

Look into Enhance the user settings #162

xiaomi7732 opened this issue Mar 9, 2022 · 3 comments
Assignees
Milestone

Comments

@xiaomi7732
Copy link
Member

Considering:

{
    "ServiceProfiler": {
        "IsDisabled": false,
        "BufferSizeInMB": "250",
        "Duration": "00:00:30", // Default duration
        "InitialDelay": "00:00:10",
        "ProvideAnonymousTelemetry": false,
        "RandomProfilingOverhead": 0.3,
        "IsSkipCompatibilityTest": false,
        "Endpoint": "https://agent.azureserviceprofiler.net",
        "SkipEndpointCertificateValidation": false,
        "PreserveTraceFile": false,
        "LocalCacheFolder": "/tmp/",
        "UploadMode": "OnSuccess",
        "NamedPipe": {
            "ConnectionTimeout": "00:00:30"
        },
        "CPUTriggerThreshold": 0.8, // Deprecating
        "MemoryTriggerThreshold": 0.8, // Deprecating

        "CPUTrigger": {
            "Threshold": 0.8,
            "Cooldown": "04:00:00",
            "Duration": "00:02:00",
            "Enabled": true
        },
        "MemoryTrigger": {
            "Threshold": 0.8,
            "Cooldown": "04:00:00",
            "Duration": "00:02:00",
            "Enabled": true
        },
        "Sampling": {
            "Enabled": true,
            "Rate": 0.3,
            "Duration": "00:02:00"
        },
        "OnDemand": {
            "Enabled": true,
            "Duration": "00:02:00"
        },
        "OneTime": {
            "Enabled": true,
            "Duration": "00:02:00"
        }
    }
}
@xiaomi7732 xiaomi7732 added this to the vNext + 1 milestone Mar 9, 2022
@TeplrGuy
Copy link

@xiaomi7732 inversion 2.21 are

"CPUTriggerThreshold": 0.8,
"MemoryTriggerThreshold": 0.8,

being deprecated?

@xiaomi7732
Copy link
Member Author

Hi @TeplrGuy, what do you mean by version 2.21? We have never delivered a version 2.21. Do you mind double check? That said, do you have concerns that we deprecating settings in the newer version, we are curious to understand why.

@xiaomi7732
Copy link
Member Author

@TeplrGuy Do you mind feed us back. It would be great if we hear suggestions / push backs in this early stage. Thanks!

@xiaomi7732 xiaomi7732 modified the milestones: vNext, vNext + 1 Apr 27, 2022
@xiaomi7732 xiaomi7732 modified the milestones: 2.5.0-beta1, vNext + 2 May 23, 2022
@xiaomi7732 xiaomi7732 modified the milestones: 2.5.0, vNext + 1 Nov 15, 2022
@xiaomi7732 xiaomi7732 modified the milestones: vNext, vNext + 1 Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants