We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug Event pipe session isn't disposed when there's exception.
To Reproduce Steps to reproduce the behavior:
For whatever reason, when there's exception, the event pipe session should be disposed upon stopping.
Expected behavior Dispose being called upon exception.
... try { if (_currentSession != null) { _... if (disposeEventSessionImmediately) { DisposeEventPipeSession(); } } _logger.LogTrace("[{typeName}] Disabled.", _typeName); } catch (Exception ex) { _logger.LogError(ex, "Unexpected exception stopping session."); // !!!!!! Dispose should have been called here !!!!!!! throw; } finally { _singleTraceSessionHandle.Release(); }
The same should be done for start logic.
The text was updated successfully, but these errors were encountered:
xiaomi7732
No branches or pull requests
Describe the bug
Event pipe session isn't disposed when there's exception.
To Reproduce
Steps to reproduce the behavior:
For whatever reason, when there's exception, the event pipe session should be disposed upon stopping.
Expected behavior
Dispose being called upon exception.
The same should be done for start logic.
The text was updated successfully, but these errors were encountered: