-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI Profiler not working well with .Net Core 3.0 and AKS #48
Comments
@Eneuman, thanks for the report. I'll take a look. I have a guess on what is happening but I will need to verify it. I'll post the cause here once I can root it. |
@Eneuman, the issue is that the TraceUploader in the package runs on .NET Core 2.x. This won't be an issue if there's .NET Core 2.x side by side with .NET Core 3.0. It is not the case in the container. While we are looking into a proper fix, here's a workaround:
...
RUN dotnet publish -c Release -o out
...
# Work around - output the new uploader for .NET Core 3.0
COPY ./Workaround/TraceUpload.zip ./out/ServiceProfiler/TraceUpload.zip
... My full dockerfile just as an FYI: FROM mcr.microsoft.com/dotnet/core/sdk:3.0 AS build-env
WORKDIR /app
# Copy csproj and restore as distinct layers
COPY *.csproj ./
RUN dotnet restore
# Copy everything else and build
COPY . ./
RUN dotnet publish -c Release -o out
# Work around - output the new uploader for .NET Core 3.0
COPY ./Workaround/TraceUpload.zip ./out/ServiceProfiler/TraceUpload.zip
# Build runtime image
FROM mcr.microsoft.com/dotnet/core/aspnet:3.0
WORKDIR /app
COPY --from=build-env /app/out .
ENTRYPOINT ["dotnet", "ServiceProfiler.EventPipe.DockerApp30.dll"] Give it a try and feel free to let us know if there's more issue. |
Manually copying the fixed app works for me. Couldn't |
@cwoolum Thanks for the comment. It is good to know that we have a working workaround. |
It would be great if the different versions could be hosted at a public endpoint and just added as a Dockerfile step. We actually add the profiler to one of our core libraries so our consuming apps actually need to have the zip manually added anyway. We also use our own custom base docker images so downloading a file and adding it to the build as a step in the Dockerfile is much simpler than manually downloading the zip and copying it in. |
@cwoolum Thanks for the feedback. Will it work for you if we post the binaries for the uploader in Github releases? |
That would be the ideal solution for me! |
The fix as been rolled out here: 2.0.0-beta1.
@cwoolum, please wait for a few days for us to release the binaries separately. |
@cwoolum The binaries have been released here: |
I'm able to easily pull the binaries. Thank you! |
When using AI Profiler together with DEV-Spaces and AKS, I receive this error in my logs.
I am creating my docker container using this build file:
I find it strange that it says that it has found .Net Core 3.0 but it needs .Net Core 2.0.
I am using the latest beta-2 package.
Any idea on how to solve this?
The text was updated successfully, but these errors were encountered: