Skip to content
This repository has been archived by the owner on Jun 10, 2020. It is now read-only.

Support correlation-context in absence of Request-Id or traceparent #901

Closed
lmolkova opened this issue Jun 11, 2019 · 2 comments
Closed
Assignees
Milestone

Comments

@lmolkova
Copy link
Member

lmolkova commented Jun 11, 2019

Correlation-Context is used by partner teams in Microsoft to propagate arbitrary key-value pairs along with request flow and in addition to tracing identifiers (Request-Id, cV or traceparent).

When 1P app instrumented with cV attempts to work with app that is instrumented with ApplicationInsights, AppInsights ignores Correlation-Context.
It happens because Correlation-Context according to spec is an extension on top of Request-Id (or traceparent) and is not read when Request-Id is not present.

We should read Correlation-Context regardless of Request-Id (traceprent) presence.

@cijothomas
Copy link
Contributor

@lmolkova Do we need this for upcoming release?

@lmolkova
Copy link
Member Author

yep, we have a partner team asking us for it (just got confirmation today). Do you want to do it along with w3c changes?

If not, that's fine - I wanted to volunteer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants