Skip to content
This repository has been archived by the owner on Jun 10, 2020. It is now read-only.

MVC BeforeAction event needs changes in ASP.NET Core 3.0 #936

Closed
lmolkova opened this issue Jul 16, 2019 · 1 comment
Closed

MVC BeforeAction event needs changes in ASP.NET Core 3.0 #936

lmolkova opened this issue Jul 16, 2019 · 1 comment
Milestone

Comments

@lmolkova
Copy link
Member

In ASP.NET Core 3.0 Mvc events payloads have changed:

  • they are now public types (but we probably can't use them as we don't depend on MVC packages)
  • properties name now start with a capital letter

https://github.com/aspnet/AspNetCore/blob/09722d1ce59d4a7740451e065256ec62cbdb32a9/src/Mvc/Mvc.Core/src/Diagnostics/MvcDiagnostics.cs#L23

We only use BeforeAction event and we need to be case-insensitive or have different logic for 2.* vs 3.0+
https://github.com/microsoft/ApplicationInsights-aspnetcore/blob/develop/src/Microsoft.ApplicationInsights.AspNetCore/DiagnosticListeners/Implementation/HostingDiagnosticListener.cs#L763

@rynowak
Copy link
Member

rynowak commented Aug 21, 2019

I'd suggest just being case-sensitive. That was the original design intent on our side.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants