Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading 30mb files as json binary properties is slow #25

Open
lodejard opened this issue Sep 25, 2018 · 1 comment
Open

Reading 30mb files as json binary properties is slow #25

lodejard opened this issue Sep 25, 2018 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@lodejard
Copy link
Contributor

Maybe this is an optimization problem, or maybe it's a bad idea to read several dozen mb of binary files as a base64 encoded json property in order to upload it to blob storage.

We should consider adding a way to declare the body of an api as coming from a file instead of being declared as a binary json property. Something like a top level property like bodyFile or input.

Should also add a command-line switch named -i|--input in order to provide multiple base paths. Reading files which are not part of the template folder would be relative to one of those paths. It should also be impossible for a workflow to read any file that isn't a sub-path of an --input directory.

@lodejard lodejard added bug Something isn't working enhancement New feature or request labels Sep 25, 2018
@lodejard
Copy link
Contributor Author

@JSchenken fyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant