Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding CORS rules to Premium account causes an error #142

Closed
v-flyuan opened this issue May 4, 2018 · 7 comments
Closed

Adding CORS rules to Premium account causes an error #142

v-flyuan opened this issue May 4, 2018 · 7 comments
Assignees
Labels
🪲 bug Issue is not intended behavior 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Milestone

Comments

@v-flyuan
Copy link

v-flyuan commented May 4, 2018

Storage Explorer Version: 1.1.0 RC

Platform: Windows/Linux/Mac

Architecture: x64

Build Number: 20180503.1

Commit: 253b437b

Regression From: Not a regression

Steps to Reproduce:

  1. Launch Storage Explorer and expand Storage Accounts.
  2. Right click 'Blob Containers' node under a premium storage account and select "Configure CORS Settings...".
  3. On the 'CORS' Settings dialog, click 'Save' directly. Verify whether save successfully or not.

Expected Experience:

Save successfully.

Actual Experience:

Pop up an error dialog. You can see the screenshot.
cors

@v-flyuan v-flyuan added the 🧪 testing Found through regular testing label May 4, 2018
@craxal
Copy link
Contributor

craxal commented May 4, 2018

Same root as #133. Already fixed.

@craxal craxal closed this as completed May 4, 2018
@craxal craxal added the ✅ duplicate Issue or pull request already exists label May 4, 2018
@craxal craxal added this to the 1.1.0 milestone May 4, 2018
@v-xuanzh v-xuanzh changed the title Pop up an error dialog after clicking 'Save' on 'CORS settings' dialog for premium account No way to add rules for premium account with an error May 15, 2018
@v-xuanzh
Copy link

The issue #133 has been fixed. But we have no way to add rules for premium account with the posted error.
Could you help to take look at it?

@v-xuanzh v-xuanzh reopened this May 15, 2018
@craxal craxal self-assigned this Jun 1, 2018
@MRayermannMSFT MRayermannMSFT modified the milestones: 1.1.0, 1.4.0 Jun 14, 2018
@MRayermannMSFT MRayermannMSFT removed the ✅ duplicate Issue or pull request already exists label Jun 14, 2018
@v-xuanzh
Copy link

v-xuanzh commented Jul 5, 2018

This issue still reproduces on 20180704.1. But it displays as the below different error
error

@craxal
Copy link
Contributor

craxal commented Jul 5, 2018

CORS is not supported for Premium Storage accounts (see documentation). So we just need to remove this action.

@craxal craxal added the 🪲 bug Issue is not intended behavior label Jul 5, 2018
@craxal craxal changed the title No way to add rules for premium account with an error Adding CORS rules to Premium account causes an error Jul 5, 2018
@craxal craxal added 🔍 pending ✅ merged A fix for this issue has been merged and removed 🔍 pending labels Jul 16, 2018
@craxal craxal closed this as completed Jul 19, 2018
@v-xuanzh
Copy link

Hi @craxal , The action 'Configure CORS Settings...' still shows on the premium context menu with build 20180724.5. So we re-open this issue.
need_to_remove

@v-xuanzh v-xuanzh reopened this Jul 25, 2018
@craxal craxal added 🔍 pending ✅ merged A fix for this issue has been merged and removed ✅ merged A fix for this issue has been merged 🔍 pending labels Jul 25, 2018
@craxal craxal closed this as completed Jul 26, 2018
@v-xuanzh
Copy link

For the original premium account, the action 'Configure CORS Setting...' is removed. But for one attached premium account, the action still displays. So we re-opened this issue.
action

@v-xuanzh v-xuanzh reopened this Jul 30, 2018
@craxal
Copy link
Contributor

craxal commented Jul 30, 2018

The visibility of this option depends on information that can only be retrieved from the management endpoint, which we don't have for attached resources. This is not a high-priority issue, so I'm closing as Won't Fix.

@craxal craxal closed this as completed Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Issue is not intended behavior 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Projects
None yet
Development

No branches or pull requests

4 participants