Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StorageExplorer does not acknowledge a moved Downloads folder when downloading a blob. #313

Closed
safalin1 opened this issue Jun 15, 2018 · 3 comments
Assignees
Labels
💡 feature request New feature or request ✅ merged A fix for this issue has been merged
Milestone

Comments

@safalin1
Copy link

Storage Explorer Version: 1.2.0
Platform/OS Version: Windows
Architecture: ia32

Steps to Reproduce:

  1. In Windows Explorer, Right click your user Downloads folder.
  2. Select the Location tab.
  3. Click the "Move..." button on the dialog, and select a new location for your Downloads folder.
  4. Once your Downloads folder has moved, Download a blob file in Storage Explorer.

Expected Experience:

On startup, Storage Explorer should default to the new location of the Windows Downloads folder.

Actual Experience:

Storage Explorer will open the Windows "Save as" dialog at the old location of the Downloads folder.
For example, if the original location of your downloads folder was "C:\Users\Username\Downloads", but you then moved the folder to "D:\Downloads". On startup, Storage Explorer will use the original location of the Downloads folder, instead of the new location.

I would like to note that this bug only happens when you first start the app - after you select the correct folder to download the blob to in Storage Explorer, the Windows prompt will remember this location for the rest of the application session.

@craxal craxal added the 💡 feature request New feature or request label Jun 15, 2018
@brcrista
Copy link

brcrista commented Jul 3, 2018

@craxal I would call this a bug, albeit a common gotcha on Windows. This can happen if an app is trying to construct the path itself like %USERPROFILE%\Downloads. The only reliable way to get the paths to special folders is to call SHGetKnownFolderPath.

@lenardg
Copy link

lenardg commented May 27, 2019

It also happens when exporting CSV from table storage. The Save dialog shows you a Downloads folder, but it is not the actual location if you moved the folder.

@craxal
Copy link
Contributor

craxal commented May 28, 2019

The best we can really do here is use the Electron API app.getPath. I checked the code, and we do something like path.join(remote.app.getPath("home"), "Downloads");. Obviously, we should do app.getPath("downloads"). I'm not sure if this calls the Windows API as mentioned by @brcrista, but like I say, that's about all we can do without writing any complicated native packages.

@JasonYeMSFT JasonYeMSFT added the ❔ investigate We need to look into this further label Apr 6, 2020
@JasonYeMSFT JasonYeMSFT added this to Committed in Storage Explorer via automation Apr 6, 2020
@JasonYeMSFT JasonYeMSFT added this to the 1.15.0 milestone Apr 6, 2020
@craxal craxal modified the milestones: 1.15.0, 1.16.0 Jul 24, 2020
@craxal craxal moved this from Committed to In Progress in Storage Explorer Sep 17, 2020
@craxal craxal moved this from In Progress to Under Review in Storage Explorer Sep 23, 2020
@craxal craxal added ✅ merged A fix for this issue has been merged and removed ❔ investigate We need to look into this further labels Sep 23, 2020
@craxal craxal closed this as completed Sep 25, 2020
Storage Explorer automation moved this from Under Review to Done Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 feature request New feature or request ✅ merged A fix for this issue has been merged
Projects
Development

No branches or pull requests

5 participants