Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to rename the blob when entering a name contains " ' " #3360

Closed
v-xinda opened this issue Aug 6, 2020 · 13 comments
Closed

Fail to rename the blob when entering a name contains " ' " #3360

v-xinda opened this issue Aug 6, 2020 · 13 comments
Assignees
Labels
⚙️ adls gen2 Related to hierarchical namespaces (ADLS Gen 2) 🧪 testing Found through regular testing
Milestone

Comments

@v-xinda
Copy link

v-xinda commented Aug 6, 2020

Storage Explorer Version: 1.15.0-dev
Build: 20200806.6
Branch: master
Platform/OS: Windows 10/ Linux Ubuntu 18.04/ MacOS Catalina
Architecture: ia32/x64
Regression From: Not a regression

Steps to reproduce:

  1. Expand one ADLS Gen2 storage account -> Blob Containers.
  2. Create one blob container -> Upload one blob -> Right click the blob -> Select 'Rename...' -> Enter "test'1".
  3. Check the result.

Expect Experience:
Succeed to rename the blob.

Actual Experience:
Fail to rename the blob when entering a name "test'1".
image

More Info:
This issue doesn't reproduce on File Shares and regular Blob Containers.

@v-xinda v-xinda added 🧪 testing Found through regular testing ⚙️ adls gen2 Related to hierarchical namespaces (ADLS Gen 2) labels Aug 6, 2020
@MRayermannMSFT MRayermannMSFT added the ⚙️ azcopy Related to AzCopy integration label Aug 6, 2020
@MRayermannMSFT
Copy link
Member

@v-xinda can you still repro this? We're having a hard time doing so. Also, can you share with us the error details?

@v-xinda
Copy link
Author

v-xinda commented Aug 11, 2020

Hi @MRayermannMSFT
This issue also reproduces on the build 20200811.2. Error details as below.
Error Details:

{
 "name": "Error",
  "message": "This request is not authorized to perform this operation using this permission.\nRequestId:16f44a82-701f-00ab-6683-6fe84a000000\nTime:2020-08-11T02:04:13.4702143Z",
  "stack": "Error: This request is not authorized to perform this operation using this permission.\nRequestId:16f44a82-701f-00ab-6683-6fe84a000000\nTime:2020-08-11T02:04:13.4702143Z\n    at new RestError (C:\\Program Files (x86)\\Microsoft Azure Storage Explorer\\resources\\app\\node_modules\\@azure\\ms-rest-js\\dist\\msRest.node.js:2400:28)\n    at C:\\Program Files (x86)\\Microsoft Azure Storage Explorer\\resources\\app\\node_modules\\@azure\\ms-rest-js\\dist\\msRest.node.js:3544:37\n    at processTicksAndRejections (internal/process/task_queues.js:93:5)",
  "code": "AuthorizationPermissionMismatch",
  "statusCode": 403
}

@JasonYeMSFT
Copy link
Contributor

@v-xinda The error message says the failure is due to missing permission. For rename (move) in ADLS Gen2, you will see such error details if you miss the "write" permission on the directory you are moving you blob into.

However, this doesn't seem to be the case. According to the issue description, you can upload a blob into the directory, meaning that you have "write" permission on that directory. Could you please make sure you try this with the write permission and see if the issue still reproduces?

@v-xinda
Copy link
Author

v-xinda commented Aug 18, 2020

@JasonYeMSFT Hi
Verified this issue on build master/20200818.4. Still reproduces.
More details please see the record: https://msit.microsoftstream.com/video/5517a1ff-0400-8385-52b4-f1eae0fd4a23

@MRayermannMSFT MRayermannMSFT added this to the 1.16.0 milestone Aug 31, 2020
@JasonYeMSFT JasonYeMSFT added the ❔ external Root cause of this issue is in another component, product, or service label Aug 31, 2020
@JasonYeMSFT JasonYeMSFT added this to Committed in Storage Explorer via automation Oct 1, 2020
@MRayermannMSFT MRayermannMSFT removed the ⚙️ azcopy Related to AzCopy integration label Oct 1, 2020
@JasonYeMSFT JasonYeMSFT removed the ❔ external Root cause of this issue is in another component, product, or service label Oct 2, 2020
@JasonYeMSFT
Copy link
Contributor

I still cannot reproduce the issue. Renaming a blob with name containing single quote ' just works fine.
image

@v-xianya
Copy link
Member

@JasonYeMSFT

Verified this issue on build 20201010.6 and 1.15.1 release. Reproduce.
image

@JasonYeMSFT
Copy link
Contributor

I managed to reproduce this issue. It only occurs when we use account name and key to authorize the rename action.

@JasonYeMSFT JasonYeMSFT added the ❔ external Root cause of this issue is in another component, product, or service label Oct 16, 2020
@JasonYeMSFT JasonYeMSFT modified the milestones: 1.16.0, 1.17.0 Oct 22, 2020
@MRayermannMSFT
Copy link
Member

Jason, please open an issue against the SDK, and then move this to 1.18.

@JasonYeMSFT JasonYeMSFT modified the milestones: 1.17.0, 1.18.0 Nov 7, 2020
@JasonYeMSFT
Copy link
Contributor

The issue is in the preview SDK and won't get fixed there. We need to upgrade to the public SDK to fix this issue.

@JasonYeMSFT
Copy link
Contributor

A blocking issues in the public SDK has been fixed here Azure/azure-sdk-for-js#11849.

@JasonYeMSFT JasonYeMSFT removed the ❔ external Root cause of this issue is in another component, product, or service label Feb 8, 2021
@JasonYeMSFT JasonYeMSFT moved this from Committed to Verifying in Storage Explorer Feb 8, 2021
@JasonYeMSFT
Copy link
Contributor

I just verified it today and it seems to have been fixed by integrating the new SDK.

Storage Explorer automation moved this from Verifying to Done Feb 17, 2021
@sid5233
Copy link

sid5233 commented Sep 20, 2023

I'm still facing this issue. If I add my public IP address only then I'm able to rename the blob.

@JasonYeMSFT
Copy link
Contributor

@sid5233 Could you open a new issue describing what you see? The original issue doesn't have anything to do with IP address. If you have a firewall setting, you are expected to add your IP in the rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ adls gen2 Related to hierarchical namespaces (ADLS Gen 2) 🧪 testing Found through regular testing
Projects
Development

No branches or pull requests

5 participants