Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aria-expanded=false is never applied to tree view elements #352

Closed
MRayermannMSFT opened this issue Jun 25, 2018 · 2 comments
Closed

aria-expanded=false is never applied to tree view elements #352

MRayermannMSFT opened this issue Jun 25, 2018 · 2 comments
Assignees
@MRayermannMSFT
Labels
:accessibility: MAS Required for MAS accessibility compliance 🪲 bug Issue is not intended behavior ✅ merged A fix for this issue has been merged
Milestone
1.3.0

Comments

@MRayermannMSFT
Copy link
Member

Fixing this should close: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/518173

Long story short, it looks like Knockout is only adding aria-expanded (with a value of true) to our tree nodes, not sure if this is a bug on Knockout's part but it should be easy to add a slightly more complicated if which forces the correct values to be used, and then no attribute to be added if the node is not expandable.
@MRayermannMSFT MRayermannMSFT added 🪲 bug Issue is not intended behavior :accessibility: MAS Required for MAS accessibility compliance labels Jun 25, 2018
@MRayermannMSFT MRayermannMSFT added this to the 1.3.0 milestone Jun 25, 2018
@MRayermannMSFT MRayermannMSFT self-assigned this Jun 25, 2018
@MRayermannMSFT MRayermannMSFT added pending ✅ merged A fix for this issue has been merged and removed pending labels Jun 25, 2018
@MRayermannMSFT
Copy link
Member Author

Merged into master for 1.3.0

@MRayermannMSFT
Copy link
Member Author

Testers have closed the bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MRayermannMSFT MRayermannMSFT

Labels
:accessibility: MAS Required for MAS accessibility compliance 🪲 bug Issue is not intended behavior ✅ merged A fix for this issue has been merged
Projects
None yet
Milestone
1.3.0
Development

No branches or pull requests
1 participant
@MRayermannMSFT