Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot reorder a message whose size is 0 B #6859

Closed
v-xianya opened this issue May 5, 2023 · 3 comments
Closed

Cannot reorder a message whose size is 0 B #6859

v-xianya opened this issue May 5, 2023 · 3 comments
Assignees
Labels
🪲 regression Issue was working in a previous version ⚙️ queues Related to queue storage 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Milestone

Comments

@v-xianya
Copy link
Member

v-xianya commented May 5, 2023

Storage Explorer Version: 1.30.0-dev
Build Number: 20230505.3
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Ventura 13.3.1 (Apple M1 Pro)
Architecture: x64
How Found: From running test cases
Regression From: Previous release (1.28.1)

Steps to Reproduce

  1. Expand one storage account -> Queues.
  2. Create a queue -> Add one message with 0 B.
  3. Add another message with content.
  4. Reorder the two messages by size.
  5. Check whether succeeds to reorder the two messages.

Expected Experience

Succeeds to reorder the two messages.

Actual Experience

Fail to reorder the two messages.

Additional Context

A message of size 0 B defaults to being the last message.

@v-xianya v-xianya added 🧪 testing Found through regular testing ⚙️ queues Related to queue storage 🪲 regression Issue was working in a previous version labels May 5, 2023
@JasonYeMSFT JasonYeMSFT added this to the 1.30.0 milestone May 8, 2023
@JasonYeMSFT JasonYeMSFT modified the milestones: 1.30.0, 1.29.1 May 8, 2023
@JasonYeMSFT JasonYeMSFT added the ❔ investigate We need to look into this further label May 8, 2023
@JasonYeMSFT
Copy link
Contributor

@craxal Please investigate the cause of the bug and see if it needs a hot fix?

@craxal
Copy link
Contributor

craxal commented May 8, 2023

Cause is due to a test that mistakes 0 for null or undefined, and null/undefined items are ordered after all defined items. To fix, thee code just needs to test more specifically for null or undefined instead of falsy values.

@JasonYeMSFT JasonYeMSFT added ✅ merged A fix for this issue has been merged and removed ❔ investigate We need to look into this further labels May 9, 2023
@v-kellyluo
Copy link

Verified this issue on the build 20230509.5. Fixed. So, we are going to close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 regression Issue was working in a previous version ⚙️ queues Related to queue storage 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Projects
None yet
Development

No branches or pull requests

5 participants