Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The red border overlaps the username box border on the 'Proxy Settings' dialog when the username is missing #7649

Closed
v-xianya opened this issue Jan 8, 2024 · 2 comments
Closed

The red border overlaps the username box border on the 'Proxy Settings' dialog when the username is missing #7649

v-xianya opened this issue Jan 8, 2024 · 2 comments
Assignees
@craxal
Labels
🪲 regression Issue was working in a previous version 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Milestone
1.33.0

Comments

@v-xianya
Copy link
Member

v-xianya commented Jan 8, 2024

Storage Explorer Version: 1.33.0-dev (96)
Build Number: 20240106.11
Branch: main
Platform/OS: Windows 10/Linux Ubuntu 22.04/MacOS Sonoma 14.2(Apple M1 Pro)
Architecture: x64/x64/x64
How Found: From running test cases
Regression From: Previous release (1.32.1)

Steps to Reproduce

  1. Launch Storage Explorer -> Click 'Edit -> Configure Proxy'.
  2. Select 'Use system proxy' as the source -> Check the option 'Use a username and password'.
  3. Check if the red border doesn't overlap the username box border.

Expected Experience

The red border doesn't overlap the username box border.
image

Actual Experience

The red border overlaps the username box border.
image
@v-xianya v-xianya added 🧪 testing Found through regular testing 🪲 regression Issue was working in a previous version labels Jan 8, 2024
@craxal
Copy link
Contributor

craxal commented Jan 8, 2024

I forgot to set the outline offset.

@craxal craxal self-assigned this Jan 8, 2024
@craxal craxal added this to the 1.33.0 milestone Jan 8, 2024
@craxal craxal added the ✅ merged A fix for this issue has been merged label Jan 8, 2024
@craxal craxal closed this as completed Jan 8, 2024
@v-xianya
Copy link
Member Author

v-xianya commented Jan 9, 2024

Verified this issue on the main build 20240109.2. Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@craxal craxal

Labels
🪲 regression Issue was working in a previous version 🧪 testing Found through regular testing ✅ merged A fix for this issue has been merged
Projects
None yet
Milestone
1.33.0
Development

No branches or pull requests
2 participants
@craxal @v-xianya