Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurePublish should not use internal packages such as code-editor #5744

Closed
hatpick opened this issue Feb 9, 2021 · 0 comments
Closed

azurePublish should not use internal packages such as code-editor #5744

hatpick opened this issue Feb 9, 2021 · 0 comments
Assignees
@VamsiModem
Labels
P1 Painful if we don't fix, won't block releasing Team: Runtime & Publishing Type: Bug Something isn't working
Milestone
R14

Comments

@hatpick
Copy link
Contributor

hatpick commented Feb 9, 2021

azurePublish or any other extensions (sitting under extensions directory) should not have knowledge about internal yarn workspace packages.

In this particular case, azurePublish wants to display a jsonEditor and should import monaco directly instead of depending on @bfc/code-editor. This causes an issue with node module discovery since it has no idea about yarn workspaces inside Composer directory it tries finding them on npm and fails.
@hatpick hatpick added Type: Bug Something isn't working Needs-triage A new issue that require triage labels Feb 9, 2021
@srinaath srinaath added Team: Runtime & Publishing and removed Needs-triage A new issue that require triage labels Feb 11, 2021
@VamsiModem VamsiModem mentioned this issue Jun 15, 2021
Merged
@GeoffCoxMSFT GeoffCoxMSFT added this to the R14 milestone Jun 30, 2021
@cwhitten cwhitten added the P1 Painful if we don't fix, won't block releasing label Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VamsiModem VamsiModem

Labels
P1 Painful if we don't fix, won't block releasing Team: Runtime & Publishing Type: Bug Something isn't working
Projects
None yet
Milestone
R14
Development

No branches or pull requests
5 participants
@cwhitten @hatpick @VamsiModem @srinaath @GeoffCoxMSFT