Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SkillDialog action automatically added when connecting to a Skill cannot select Skill endpoint #7153

Closed
2 of 8 tasks
darrenj opened this issue Apr 20, 2021 · 11 comments · Fixed by #7475
Closed
2 of 8 tasks
Assignees
Labels
P0 Must Fix. Release-blocker ShipRoom-Approved Ship room has approved this issue for the release Skills Workflow Type: Bug Something isn't working
Milestone

Comments

@darrenj
Copy link

darrenj commented Apr 20, 2021

Describe the bug

When connecting a Skill to an basic (empty) bot a trigger is added for the Skill. Within that trigger is a SkillDialog custom action. When testing you get a Value cannot be null. (Parameter uriString) error which appears to be because the Skill Endpoint selection isn't selected automatically (a bug) and cannot be manually selected.

Version

1.4.0-nightly.237101

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Connect a skill to a Bot (e.g. https://djtest6.azurewebsites.net/manifests/djbfskill1-2-1-manifest.json)
  2. Observe that the Skill endpoint setting on SkillDialog action in newly created trigger isn't set
  3. Skill isn't invoked

Screenshots

image

@darrenj darrenj added Type: Bug Something isn't working Needs-triage A new issue that require triage labels Apr 20, 2021
@cwhitten cwhitten added Skills Workflow and removed Needs-triage A new issue that require triage labels Apr 20, 2021
@luhan2017
Copy link
Contributor

Synced with Darren offline, This can't be reproduced on the latest main branch, let me know if you have this reproduced.

@darrenj darrenj reopened this Apr 28, 2021
@darrenj
Copy link
Author

darrenj commented Apr 28, 2021

Just reopened as can repro in 2.0.0.nightly.239644.

image

Observe that Skill Manifest isn't set on action. Unable to select it in UK

image

Note that I deliberately have not published my Bot to Azure and got an AppId/Password set locally

@sgellock
Copy link
Member

sgellock commented May 3, 2021

Shiproom - approved

@sgellock sgellock assigned tdurnford and unassigned luhan2017 May 3, 2021
@sgellock sgellock added the ShipRoom-Approved Ship room has approved this issue for the release label May 3, 2021
@sgellock
Copy link
Member

sgellock commented May 3, 2021

Shiproom - @darrenj we're unable to repo. Are you?

@tdurnford
Copy link
Collaborator

@darrenj @sgellock I'm not able to repro either.

image

@darrenj Are you using ngrok to configure your Skill host endpoint URL?

image

@darrenj
Copy link
Author

darrenj commented May 4, 2021

I reproed just now, and have been able consistently. 2.0.0-nightly.242275

image

Note the endpoint drop-down is blank, and I can't choose anything
image
..

@darrenj
Copy link
Author

darrenj commented May 4, 2021

This is not even getting to the point of calling the skill so not ngrok, I did double check in case I was misreading the error message reason but even with ngrok configured and skillhostendpoint configured I get the same issue

@tdurnford
Copy link
Collaborator

@darrenj can you check your bot settings to make sure runtimeSettings.skill['djbfskill1'] is set correctly? I'm not seeing this issue in the latest nightly - v2.0.0-nightly.242720.c3b8105 - using your weather skill.

@darrenj darrenj reopened this May 6, 2021
@darrenj
Copy link
Author

darrenj commented May 6, 2021

I can repro this in todays build. Just created a repro video and will share with @tdurnford

@cwhitten
Copy link
Member

cwhitten commented May 6, 2021

@darrenj this was auto-closed and a nightly is running for you test

@darrenj
Copy link
Author

darrenj commented May 6, 2021

Confirmed fixed in #7475

image

@darrenj darrenj closed this as completed May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 Must Fix. Release-blocker ShipRoom-Approved Ship room has approved this issue for the release Skills Workflow Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants