Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fit & finish - UI Copy | Chrome and left nav #7569

Closed
mareekuh opened this issue May 3, 2021 · 2 comments · Fixed by #7609
Closed

Fit & finish - UI Copy | Chrome and left nav #7569

mareekuh opened this issue May 3, 2021 · 2 comments · Fixed by #7609
Assignees
@cwhitten @Kaiqb @beyackle
Labels
P0 Must Fix. Release-blocker ShipRoom-Approved Ship room has approved this issue for the release Type: Bug Something isn't working
Milestone
R13

Comments

@mareekuh
Copy link
Contributor

mareekuh commented May 3, 2021 •
edited
Loading

Chrome & left nav UI Copy
White cells = existing copy
Yellow/blue cells = new copy

Link to 'live' copy on 'Chrome & nav' tab: https://microsoft.sharepoint.com/:x:/r/teams/ConversationalAI785/_layouts/15/Doc.aspx?sourcedoc=%7B6B1FACBD-B5FE-4AD2-A35B-995635C1696B%7D&file=glossary.xlsx&action=edit&mobileredirect=true&wdPreviousSession=36539654-a42b-4b87-be1b-de96507b4422&wdOrigin=TEAMS-ELECTRON.teams.undefined&cid=676cf454-61e0-4182-bd27-39044bb51cea

Home_copy

Leftnav_copy
@mareekuh mareekuh added Type: Bug Something isn't working Needs-triage A new issue that require triage labels May 3, 2021
@mareekuh mareekuh changed the title Fit & finish - UI Copy | Home page Fit & finish - UI Copy | Chrome and left nav May 3, 2021
@benbrown benbrown added the P0 Must Fix. Release-blocker label May 4, 2021
@benbrown benbrown added this to the R13 milestone May 4, 2021
@sgellock
Copy link
Member

sgellock commented May 4, 2021

Shiproom - assuming low risk fixes, and not removing any existing content, only replacing appropriately, approving as today is fit and finish day. must be merged by EOD today

@sgellock sgellock added the ShipRoom-Approved Ship room has approved this issue for the release label May 4, 2021
@beyackle beyackle mentioned this issue May 4, 2021
Merged
@sgellock
Copy link
Member

sgellock commented May 5, 2021

Shiproom - approved. @beyackle can you get this merged ASAP, we're going to kick off another nightly with these changes and a few more.

@sgellock sgellock removed the Needs-triage A new issue that require triage label May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cwhitten cwhitten

@Kaiqb Kaiqb

@beyackle beyackle

Labels
P0 Must Fix. Release-blocker ShipRoom-Approved Ship room has approved this issue for the release Type: Bug Something isn't working
Projects
None yet
Milestone
R13
Development

Successfully merging a pull request may close this issue.

fix: update left nav and top bar strings microsoft/BotFramework-Composer
6 participants
@benbrown @sgellock @cwhitten @Kaiqb @mareekuh @beyackle