Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot responses failing to take after creating a common template #7888

Closed
2 of 8 tasks
JonathanFingold opened this issue May 21, 2021 · 2 comments
Closed
2 of 8 tasks
Assignees
Labels
Type: Bug Something isn't working

Comments

@JonathanFingold
Copy link
Contributor

Describe the bug

Replace an existing response with a template. Press Enter. End up with the Send a response property pane not agreeing with the authoring canvas.

Version

Version: 2.0.0-nightly.246170.8fa93
Electron: 8.2.4
Chrome: 80.0.3987.165
NodeJS: 12.13.0
V8: 8.0.426.27-electron.0

Browser

  • Electron distribution
  • Chrome
  • Safari
  • Firefox
  • Edge

OS

  • macOS
  • Windows
  • Ubuntu

To Reproduce

Steps to reproduce the behavior:

  1. Create a bot with a skill.
  2. Make sure the skill has a trigger with a Send a response action in it.
  3. Go to the Bot responses view. Fight with the editor for a while, give up, switch to show code, and add this template to the common responses for the skill.
    # DescribeWeather(weather)
    - It is "${dialog.weather}" in ${dialog.city} in ${dialog.country} and the temperature is ${dialog.fahrenheit}°F or ${dialog.celsius}°C. Have a nice day...
    
  4. Go back to the Create view and the Send a response action in the skill.
  5. Remove the existing response, then add the following in its place:
    ${DescribeWeather(dialog.weather)}
    
  6. Error: Notice that the authoring canvas still shows the old template value.
  7. Error: Select a different action, then reselect the Send a response action. Notice the value you just entered, repeatedly, has been clobbered, again.

Expected behavior

It works, or it displays some error explaining why it has not took. It does not pretend to sort of work.

Screenshots

image

Additional context

@JonathanFingold JonathanFingold added Type: Bug Something isn't working Needs-triage A new issue that require triage labels May 21, 2021
@emgrol
Copy link
Contributor

emgrol commented May 21, 2021

We tried a few scenarios. I have a stand alone root bot (created from the Empty bot template) and don't have any issues. I suspect this may be a skill issue.

@ryanisgrig ryanisgrig removed the Needs-triage A new issue that require triage label May 24, 2021
@hatpick
Copy link
Contributor

hatpick commented May 24, 2021

@JonathanFingold I believe this was resolved by PR #7842. that was merged in on Friday. Can you check the latest nightly to see if your issue is resolved.

@hatpick hatpick closed this as completed May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants