Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulator - switching between chat tabs is really slow #1157

Closed
mewa1024 opened this issue Dec 7, 2018 · 4 comments
Closed

Emulator - switching between chat tabs is really slow #1157

mewa1024 opened this issue Dec 7, 2018 · 4 comments
Assignees

Comments

@mewa1024
Copy link

mewa1024 commented Dec 7, 2018

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Version

nightly 4.1.45039 (but was also slow in previous versions)

Describe the bug

Give a clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

  1. Open a bot.
  2. Open a chat with an endpoint.
  3. Open another chat with endpoint.
  4. Click on the Welcome tab.
  5. Click back on the endpoint tab.
  6. It can take more than 1 second for Emulator to react.

Expected behavior

The tab should load more quickly. If it is a loading problem, there should be some feedback to the user that tab is refreshing so they don't keep clicking on the tab.

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

I was using the Basic bot template which starts with an adaptive card.

[bug]

@mewa1024 mewa1024 added the 4.3 label Dec 7, 2018
@tonyanziano
Copy link
Contributor

We know that this is related to the number of Webchat (livechat / transcript) tabs open. We have a hunch that it is due to excessive re-rendering of the Webchat component.

@justinwilaby
Copy link
Contributor

Another note, this seems to be exacerbated when Adaptive Cards are being rendered in WebChat.

@tonyanziano
Copy link
Contributor

@justinwilaby and I have confirmed that this is due to the performance of the UpdateConversationMenu command on the main side.

I will look into how to optimize the re-drawing of the app menu.

@tonyanziano
Copy link
Contributor

Addressed in #1180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants