Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify SSL certificates #1246

Closed
martinoss opened this issue Jan 21, 2019 · 2 comments
Closed

Allow to specify SSL certificates #1246

martinoss opened this issue Jan 21, 2019 · 2 comments
Assignees
Labels
Bot Services equired for internal Azure reporting. Do not delete. Do not change color. Customer As opposed to development work item. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. Enhancement New feature or request to evolve an additional feature

Comments

@martinoss
Copy link

martinoss commented Jan 21, 2019

Is your feature request related to a problem? Please describe.
In our company, SSL traffic is being intercepted, also for tentant restriction reasons (https://docs.microsoft.com/en-us/azure/active-directory/manage-apps/tenant-restrictions). The company's root certificate is installed in the clients Windows Trusted Root Certification Authorities.
I believe because for cross platform reasons, many newer Microsoft tools have it's own handling of trusting certificate chains. Now, in the Bot Framework Emulator I get this error:
16:24:24]request to https://login.microsoftonline.com/botframework.com/oauth2/v2.0/token failed, reason: self signed certificate in certificate chain

Describe the solution you'd like
Like in Microsoft Azure Storage Explorer, it should be possible to import certificates to be trusted.

Describe alternatives you've considered
Rely on Windows certificate store or document a way to specify additional trusted certificates.

Additional context
image

@martinoss
Copy link
Author

martinoss commented Jan 22, 2019

Current workaround for me is disabling TLS verification for node:

image

I edited the emulator's shortcut target to
C:\Windows\System32\cmd.exe /c "SET NODE_TLS_REJECT_UNAUTHORIZED=0&& START ^"^" ^"C:\Program Files (x86)\Bot Framework Emulator\Bot Framework Emulator.exe^" --remote-debugging-port=8881"
(remote debugging parameter can be omitted)

@jameslew jameslew added Customer As opposed to development work item. Enhancement New feature or request to evolve an additional feature labels Jul 23, 2019
@cwhitten
Copy link
Member

Thank you @martinoss for the workaround. Closing this issue as we do not have plans to bring this functionality into the Emulator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services equired for internal Azure reporting. Do not delete. Do not change color. Customer As opposed to development work item. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. Enhancement New feature or request to evolve an additional feature
Projects
None yet
Development

No branches or pull requests

3 participants