Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining sidecar debugging issues #1443

Closed
20 tasks done
justinwilaby opened this issue Apr 22, 2019 · 0 comments
Closed
20 tasks done

Remaining sidecar debugging issues #1443

justinwilaby opened this issue Apr 22, 2019 · 0 comments
Assignees

Comments

@justinwilaby
Copy link
Contributor

justinwilaby commented Apr 22, 2019

Remaining Sidecar debugging issues:

P0's

  • Label color contrast issues

  • Bot State selected color contrast issues

  • Graph/Json tab focus indication

  • Switching to sidecar mode after failing to open a bot file produces a blank screen

  • Slider on edge of webchat can get stuck unless you pull it waaaay over to the right side of the app. (tony) Gave webchat panel a minimum width of 200px. #1460

  • Toggling back to Emulator mode from Sidecar has zero UI indication of the mode switch

  • "Diff with previous" appears to only utilize the most recent bot state

  • Bot State element revisions (Justin) Updated bot state element according to new design #1458
    Colors: (theme-specific)
    - Non-selected bot states should be grey
    - Selected Bot State should be white
    - On hover of any Bot State should be white
    - In diff mode, the "previous" diffed bot state font should be grey
    - In diff mode, the previous bot state indicator should be red, not blue

  • Default to the JSON view instead of the graph view, re-order the tabs in the extension pane (Tony) Bot state visualizer now defaults to JSON viewer. #1457

  • Welcome Page changes (Chris) Welcome Page changes for debug mode #1461
    When in sidecar mode, change the following:
    1. Remove the My Bots box
    2. Remove the "Sign in with Azure controls"
    3. Remove the "create a new bot configuration" text + link
    5. Change Heading copy to say:

    Bot Framework Emulator
    Bot Inspector
    Version 4 (BETA)

  • Documentation (Justin) Jwilaby/debugging doc #1463
    - Add a link that on the Welcome page in Sidecar mode that opens the Sidecar Debugging Doc
    - Add a Sidecar Debugging Doc as a tabbed document (Copy incoming) (Justin)
    - Add a Sidecar link in the Help menu that when clicked opens the Sidecar debugging doc in a new tab

When SDK bits are ready:

  • Infrastructure changes (Justin) Reverted changes that supported A fixed emulator port #1465
    - Remove starting a restify server on a fixed port (9000) when entering Sidecar mode
    - Cleanup additional logic pertaining to this server:port

  • Bot Connections (Tony)
    - Connect to a bot in Sidecar mode via url
    - Issue /INSPECT open command to bot when connection initiate

  • Token storage/rendering (Justin)
    - Receive /INSPECT connect <guid> command on response of /DEBUG open command and store it somewhere
    - Render /INSPECT connect <token> command as an Activity in the WebChat control as the first interactable element in the conversation tab. When clicked, the JSON pane exposes the command

  • Bot State context menu breaks (Justin) Fixed an NPE when copying text from a bot state message #1500
    - After right clicking on "Bot State" and selecting "copy text", right clicking on "Bot State" no longer brings up dropdown menu

  • Opening any .bot file in Emulator mode prompts switching debug modes and closes all tabs (Justin) Fixed an issue with debug mode switching #1501
    - This occurs when toggling between .bot files in Emulator mode, or opening your very first .bot file without any .bot files open.

  • Address inspector-preload path in slightly better way (Tony)
    - One option: Add a new field to the clientAwareSettings state on load to referencing this special path to the preload file.

  • Hide Graph viz altogether for Beta (Chris)
    - The feedback has been overwhelming. We saw large state trees in the Bug Bash and it was less comprehensible than looking at the raw JSON. We will revisit after \BUILD.

  • CHANNELS.md updates (Chris)

    • Adjust middleware example to include parameters passed in to the middleware
    • Adjust parts about deployment to azure, bot channel registration on the portal is enough using ngrok and localhost.

P1's

  • Save urls supplied when connecting to a bot via url in a MRU structure. Exposed as dropdown list/autocomplete as users are inputting url characters like the html5 datalist. (Tony)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants