Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Up/down arrow for send history #1091

Closed
compulim opened this issue Aug 16, 2018 · 6 comments · Fixed by #1678
Closed

Up/down arrow for send history #1091

compulim opened this issue Aug 16, 2018 · 6 comments · Fixed by #1678
Assignees
@a-b-r-o-w-n
Labels
front-burner p1 Painful if we don't fix, won't block releasing size-m 1-3 days
Projects
4.3 Prioritization
Milestone
v4.3

Comments

@compulim
Copy link
Contributor

compulim commented Aug 16, 2018 •
edited

Background

Up/down arrow on an empty send box would load the last sent history. The history could be stored in sessionStorage for short-term memory.

Will also need to consider multi-line text area.
@compulim compulim added the story label Aug 16, 2018
@compulim compulim added this to the v4 milestone Aug 16, 2018
@compulim compulim self-assigned this Aug 16, 2018
@compulim compulim changed the title Up/down arrow for send history Sample: up/down arrow for send history Oct 30, 2018
@compulim compulim added Sample Implement PoC or sample code 4.2 and removed Story labels Oct 30, 2018
@compulim compulim modified the milestones: v4, v4.2 Oct 30, 2018
@sgellock sgellock added 4.3 and removed 4.2 labels Nov 27, 2018
@corinagum corinagum added Approved front-burner p1 Painful if we don't fix, won't block releasing and removed Sample Implement PoC or sample code labels Nov 28, 2018
@compulim compulim modified the milestones: v4.2, v4.3 Nov 28, 2018
This was referenced Nov 29, 2018
Closed
Closed
@compulim compulim added p0 Must Fix. Release-blocker and removed p1 Painful if we don't fix, won't block releasing labels Nov 30, 2018
@compulim compulim added the size-m 1-3 days label Dec 8, 2018
@compulim compulim modified the milestone: v4.3 Dec 18, 2018
@compulim compulim removed their assignment Dec 18, 2018
@compulim compulim moved this from P0 to P1 in 4.3 Prioritization Dec 18, 2018
@corinagum corinagum added the p1 Painful if we don't fix, won't block releasing label Dec 18, 2018
@corinagum corinagum removed the p0 Must Fix. Release-blocker label Dec 18, 2018
@corinagum
Copy link
Contributor

corinagum commented Jan 16, 2019 •
edited

Related to #58 , #124

@corinagum corinagum added the needs-design-input UX/UI design item label Jan 16, 2019
@compulim
Copy link
Contributor Author

Notes to implementor

  • Save send history in memory
  • Try a few scenarios
    • UP
    • UP, UP (should show 2nd last)
    • UP, DOWN (should empty out)
    • UP, LEFT, UP (should show 2nd last)
    • UP, then type something (should append)
    • UP, DOWN, DOWN, UP (should show the last one)

@cwhitten
Copy link
Member

cwhitten commented Jan 18, 2019 •
edited

We want to keep the 25 recent messages and then start evicting.

Stack behavior:

Toggling to an element and making a modification doesn't mutate the stack element, but pushes a new element on the stack.

@cwhitten cwhitten assigned a-b-r-o-w-n and unassigned mewa1024 Jan 18, 2019
@cwhitten cwhitten changed the title Sample: up/down arrow for send history Up/down arrow for send history Jan 28, 2019
@a-b-r-o-w-n a-b-r-o-w-n moved this from P1 to In-Flight in 4.3 Prioritization Jan 30, 2019
@a-b-r-o-w-n a-b-r-o-w-n mentioned this issue Jan 31, 2019
Merged
@a-b-r-o-w-n a-b-r-o-w-n moved this from In-Flight to Review in 4.3 Prioritization Jan 31, 2019
4.3 Prioritization automation moved this from Review to Done Feb 4, 2019
@khmerforce
Copy link

@corinagum can the v4 webchat store the botchat history? for example, if you refresh the page, the chat will resume instead of clearing. Thank you!

@corinagum
Copy link
Contributor

Please see #365 and #1674 for storing history feature :) It's not provided by Web Chat yet, but there are a few people who are implementing it themselves. If you need further support in building your bot and surrounding app, please consider asking how to questions on Stack Overflow.

@mewa1024
Copy link

(Removing the "Design needed" label. Chris's comment above describes behavior.)

@mewa1024 mewa1024 removed the needs-design-input UX/UI design item label Feb 25, 2019
@corinagum corinagum mentioned this issue Mar 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a-b-r-o-w-n a-b-r-o-w-n

Labels
front-burner p1 Painful if we don't fix, won't block releasing size-m 1-3 days
Projects
No open projects
4.3 Prioritization
  
Done
Milestone
v4.3
Development

Successfully merging a pull request may close this issue.

add chat send history sample a-b-r-o-w-n/BotFramework-WebChat
7 participants
@sgellock @cwhitten @compulim @a-b-r-o-w-n @corinagum @mewa1024 @khmerforce