Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAS4.1.2]Name property is not properly defined for 'Accessibility' Group. #1334

Closed
priysn opened this issue Nov 12, 2018 · 2 comments · Fixed by #1506
Closed

[MAS4.1.2]Name property is not properly defined for 'Accessibility' Group. #1334

priysn opened this issue Nov 12, 2018 · 2 comments · Fixed by #1506
Assignees
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior. front-burner size-m 1-3 days

Comments

@priysn
Copy link

priysn commented Nov 12, 2018

Actual Result:
Name property is not properly defined for "Accessibility" Group.
When focus is landing on "Accessibility" group, narrator is reading only 'group'.

Note - Issue repro on all controls which appearing after hit the 'Help' message.
2. URL -> Help -> Hero Card Button -> New content loaded -> Name property is not properly define and narrator reading group when focus is landing on the whole section/group. Attachment - "MAS4.1.2_Name property for Hero card content"
3. URL -> Help -> Video card-> New content loaded -> Name property is not properly define and narrator reading group. Attachment - "MAS4.1.2_Name property for ‘Microsoft Band’ text"

Expected Result:
Name property should be properly define for "Accessibility" Group.

Repro Steps:

  1. Open URL https://microsoft.github.io/BotFramework-WebChat/full-bundle/ in Edge browser.
  2. Notice 'Upload File' and 'Send' button icons present in bottom of screen.
  3. Type 'Help' in the input control at the bottom of the screen and hit enter (or click on send button).
  4. Open Narrator (Ctrl+Win. Key+Enter)
  5. Page will upload, Navigate to the 'Accessibility' group using Tab key.
  6. Observe that Name property is not properly define for 'Accessibility' Group.

User Impact:
If Name,State and Role property is not defined properly for controls then the users will get confuse about the purpose of that control.

MAS Reference:
MAS4.1.2 - Name,Role,Value

Test Environment:
OS: Windows 10
OS Build: 17134.345
OS Version: 1803
Browser: Edge
Tool: Narrator

Attachment:

  1. MAS4.1.2_Name for groups.zip
  2. MAS4.1.2_Name property for Hero card content.zip
  3. MAS4.1.2_Name property for Microsoft Band text.zip
@priysn priysn added bug Indicates an unexpected problem or an unintended behavior. area-accessibility HCL_BotFramework_WebChat labels Nov 12, 2018
@priysn priysn changed the title Name of the 'Groups' does not defined. Name property is not properly define for "Accessibility" Group. Nov 15, 2018
@priysn priysn changed the title Name property is not properly define for "Accessibility" Group. [MAS4.1.2]Name property is not properly define for "Accessibility" Group. Nov 15, 2018
@priysn priysn self-assigned this Nov 26, 2018
@priysn priysn changed the title [MAS4.1.2]Name property is not properly define for "Accessibility" Group. [MAS4.1.2]Name property is not properly defined for 'Accessibility' Group. Nov 26, 2018
@corinagum corinagum added this to the v4.3 milestone Nov 28, 2018
@corinagum corinagum self-assigned this Dec 7, 2018
@corinagum
Copy link
Contributor

corinagum commented Dec 7, 2018

Try adding the title (name) to the speak property on the group adaptive card MockBot index.ts ln 268 and see if this fixes the issue -- if so, this is possibly a Mock Bot issue.

On ThumbnailCardAttachment.js, use the Adaptive Card builder to add the speak property.
if it works, then look at all rich cards in Web Chat and see if we need to add the same thing.

@Amit8527510735
Copy link

Amit8527510735 commented Nov 17, 2020

#HCL;#Accessibility;#HCL_BotFramework_WebChat;#A11yMAS;#WCAG4.1.2;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior. front-burner size-m 1-3 days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants