Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAS4.1.2] Name/ Alt-text property is not proprly defined for Images. #1339

Closed
priysn opened this issue Nov 13, 2018 · 3 comments
Closed

[MAS4.1.2] Name/ Alt-text property is not proprly defined for Images. #1339

priysn opened this issue Nov 13, 2018 · 3 comments
Assignees
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior. external-adaptive-cards front-burner p0 Must Fix. Release-blocker

Comments

@priysn
Copy link

priysn commented Nov 13, 2018

Actual Result:
When focus lands on the Image then narrator is reading 'Group'.
Name property does not defined properly for 'Image'.

Note - Same issue repro at -

  1. URL-> Help-> Show a simple Adaptive cards button - Name property does not defined proerly for uploaded content after activate the Show a simple Adaptive cards button button, narrator reading 'Group' while focus lands on the Content with help of the Tab key. Attachment " MAS4.1.2_Name for uploaded content"
  2. URL-> Help-> Show an Adaptive cards with all types of inputs - New Uploaded data -> Show Cards button -> Images - Focus lands on the images while navigate in scan mode, narrator is reading 'Group'.
    Attachment " MAS4.1.2_Name for Image".
  3. Same issue repro on all decorative images, narrator is reading group while navigate in scan mode, Name property does not defined properly for decorative images.

Expected Result:
Name property should be defined properly for 'Image'.

Repro Steps:

  1. Open URL https://microsoft.github.io/BotFramework-WebChat/full-bundle/ in Edge browser.
  2. Notice 'Upload File' and 'Send' button icons present in bottom of screen.
  3. Type 'Help' in the input control at the bottom of the screen and hit enter (or click on send button).
  4. Content will upload, Navigate to any "Show a rich message using Adaptive cards" button by using Tab key and press Enter on it.
  5. New data will upload.
  6. Open Narrator with Scan mode (Caps+Space key)
  7. Navigate to the new uploaded content by using Up/Down arrow keys.
  8. Observe that name property is not defined properly for images and narrator is reading "group".

User Impact:
If Name,State and Role property is not defined properly for controls then the users will get confuse about the purpose of that control.

MAS Reference:
MAS4.1.2 - Name,Role,Value

Test Environment:
OS: Windows 10
OS Build: 17134.345
OS Version: 1803
Browser: Edge
Tool: Narrator

Attachment:

  1. Usable_Name for the image does not defined properly.zip
  2. MAS4.1.2_Name for uploaded content.zip
  3. MAS4.1.2_Name for Image.zip
@priysn priysn added bug Indicates an unexpected problem or an unintended behavior. area-accessibility HCL_BotFramework_WebChat labels Nov 13, 2018
@sgellock sgellock added the 4.2 label Nov 13, 2018
@priysn priysn removed the 4.2 label Nov 14, 2018
@priysn priysn changed the title Name property does not defined properly for 'Image'. [MAS4.1.2] Name property does not defined properly for 'Image'. Nov 15, 2018
@priysn priysn changed the title [MAS4.1.2] Name property does not defined properly for 'Image'. [MAS4.1.2] Name/ Alt-text property is not proprly defined for Images. Nov 27, 2018
@priysn priysn self-assigned this Nov 27, 2018
@compulim compulim added the p0 Must Fix. Release-blocker label Nov 27, 2018
@compulim
Copy link
Contributor

There are two issues here.

Bug on Adaptive Cards

If we didn't define alt in the image, Adaptive Cards generated <img alt="undefined">. We repro-ed this bug on https://adaptivecards.io/samples/SportingEvent.html.

image

Not able to repro

We used Narrator on Edge. We heard "image undefined", instead of "group". So we are not able to repro.

@corinagum
Copy link
Contributor

corinagum commented Dec 3, 2018

Confirmed as external by accessibility team: Adaptive Cards issue can be found here.

@Amit8527510735
Copy link

Amit8527510735 commented Nov 17, 2020

#HCL;#Accessibility;#HCL_BotFramework_WebChat;#A11yMAS;#WCAG4.1.2;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior. external-adaptive-cards front-burner p0 Must Fix. Release-blocker
Projects
None yet
Development

No branches or pull requests

5 participants