Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAS1.4.3]Luminosity Contrast Ratio of 'Heading text' which appears after ''Adaptive cards that is broken because of invalid language' button is less than required. #1341

Closed
priysn opened this issue Nov 13, 2018 · 3 comments
Assignees
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior. front-burner p1 Painful if we don't fix, won't block releasing

Comments

@priysn
Copy link

priysn commented Nov 13, 2018

Actual Result:
Luminosity Contrast Ratio of 'Text' which appears after ''Adaptive cards that is broken because of invalid language' button is 4.0:1.

Note - Same issue repro at -

  1. 'Text' which appear after ''Adaptive cards that is broken because of invalid Version' button is 4.0:1.
  2. Text 'No renderer for this attachment' appear after activating "Show an attachment of unknown type" button.

Expected Result:
Luminosity Contrast Ratio for 'Heading Text - No renderer for this attachment' should be greater than or equal to 4.5:1.

Repro Steps:

  1. Open URL https://microsoft.github.io/BotFramework-WebChat/full-bundle/ in Edge browser.
  2. Notice 'Upload File' and 'Send' button icons present in bottom of screen.
  3. Type 'Help' in the input control at the bottom of the screen and hit enter (or click on send button).
  4. Content will upload, Navigate to any "Adaptive cards that is broken because of invalid language" button by using Tab key and press Enter on it.
  5. New data will upload.
  6. Open 'Colour Contrast Analyser' and select Foreground & Background color of mentioned elements one by one.
  7. Observe that Luminosity Contrast Ratio of text is less then 4.5:1.

User Impact:
Users with low vision or Color blindness will find it difficult to access content with low luminosity contrast ratio.

MAS Reference:
MAS 1.4.3 – Contrast (Minimum) (17)

Test Environment:
OS: Windows 10
OS Build: 17134.345
OS Version: 1803
Browser: Edge
Tool: Color Contrast Analyser

Attachment:
mas1 4 3_contrast ratio for text

@priysn priysn added bug Indicates an unexpected problem or an unintended behavior. area-accessibility MAS1.4.3 labels Nov 13, 2018
@priysn priysn changed the title [MAS1.4.3]Luminosity Contrast Ratio of 'Text' which appear after ''Adaptive cards that is broken because of invalid language' button is less than required. [MAS1.4.3]Luminosity Contrast Ratio of 'Heading text' which appear after ''Adaptive cards that is broken because of invalid language' button is less than required. Nov 13, 2018
@sgellock sgellock added the 4.2 label Nov 13, 2018
@priysn priysn changed the title [MAS1.4.3]Luminosity Contrast Ratio of 'Heading text' which appear after ''Adaptive cards that is broken because of invalid language' button is less than required. [MAS1.4.3]Luminosity Contrast Ratio of 'Heading text' which appears after ''Adaptive cards that is broken because of invalid language' button is less than required. Nov 19, 2018
@priysn priysn changed the title [MAS1.4.3]Luminosity Contrast Ratio of 'Heading text' which appears after ''Adaptive cards that is broken because of invalid language' button is less than required. [MAS1.4.3]Luminosity Contrast Ratio of 'Heading text' which appears after ''Adaptive cards that is broken because of invalid language' button is less than required. Nov 27, 2018
@priysn priysn self-assigned this Nov 27, 2018
@corinagum corinagum assigned corinagum and unassigned priysn Nov 27, 2018
@compulim
Copy link
Contributor

Please change the red color to #EF0000.

@corinagum
Copy link
Contributor

Related to #1354

@seaen seaen added the p1 Painful if we don't fix, won't block releasing label Nov 28, 2018
@compulim compulim modified the milestones: v4.4, v4.2 Nov 28, 2018
@corinagum corinagum added 4.3 and removed 4.2 labels Nov 30, 2018
@Amit8527510735
Copy link

Amit8527510735 commented Nov 17, 2020

#HCL;#Accessibility;#HCL_BotFramework_WebChat;#A11yMAS;#WCAG1.4.3;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior. front-burner p1 Painful if we don't fix, won't block releasing
Projects
None yet
Development

No branches or pull requests

6 participants