Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in "Integrate with React" section in README.md? #1425

Closed
robbiew opened this issue Dec 2, 2018 · 1 comment · Fixed by #1506
Closed

Error in "Integrate with React" section in README.md? #1425

robbiew opened this issue Dec 2, 2018 · 1 comment · Fixed by #1506
Assignees
@corinagum
Labels
front-burner p1 Painful if we don't fix, won't block releasing
Milestone
v4.3

Comments

@robbiew
Copy link

robbiew commented Dec 2, 2018 •
edited

https://github.com/Microsoft/BotFramework-WebChat/blob/master/README.md

import DirectLine from 'botframework-directlinejs'

should be

import { DirectLine } from 'botframework-directlinejs'

per Stack Overflow

@robbiew robbiew changed the title Error in "Integrate with React" section in readme Error in "Integrate with React" section in README.md Dec 2, 2018
@robbiew robbiew changed the title Error in "Integrate with React" section in README.md Error in "Integrate with React" section in README.md? Dec 2, 2018
@Kartik1607
Copy link

Great catch. 👍

@compulim compulim added Approved front-burner p1 Painful if we don't fix, won't block releasing labels Dec 3, 2018
@corinagum corinagum self-assigned this Dec 3, 2018
@corinagum corinagum mentioned this issue Dec 18, 2018
Merged
@compulim compulim added this to the v4.3 milestone Dec 18, 2018
@corinagum corinagum removed this from P1 in 4.3 Prioritization Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

Labels
front-burner p1 Painful if we don't fix, won't block releasing
Projects
None yet
Milestone
v4.3
Development

Successfully merging a pull request may close this issue.

Accessibility & Icon fixes corinagum/BotFramework-WebChat
4 participants
@robbiew @compulim @corinagum @Kartik1607