Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pollingInterval and conversationId update in createDirectline.js #1652

Closed
sanoorvishwa opened this issue Jan 28, 2019 · 3 comments
Closed

pollingInterval and conversationId update in createDirectline.js #1652

sanoorvishwa opened this issue Jan 28, 2019 · 3 comments
Labels
community-help-wanted This is a good issue for a contributor to take on and submit a solution Good first bug

Comments

@sanoorvishwa
Copy link

sanoorvishwa commented Jan 28, 2019

@compulim We have requirement to update the directline polling interval when the bot is minimized and maximized. Could you please update the createDirectline.js interface for the same? Any reason why these are omitted in the initial release though the directline supports it?

Thanks,
Vishwa

@sanoorvishwa sanoorvishwa changed the title pollingInterval pollingInterval and conversationId update in createDirectline.js Jan 28, 2019
@ghost
Copy link

ghost commented Jan 28, 2019

I think fix for #1613 has added 'conversationId' in createDirectline.js interface. Similarly pollingInterval can also be added

@compulim
Copy link
Contributor

@neetu-das thanks for the reference. You have keen eyes. 👀

@sanoorvishwa Because we try to whitelist stuff in, instead of blacklist stuff out. 😉

And also, today, what we can pass to DLJS is also quite arbitrary IMO. We need to revisit reconnecting story in DirectLineJS to make sure it work as expected (what I heard from people is that it is not quite working.)

Please feel free to file a PR for this fix (pollingInterval). I can help you work on CHANGELOG.md and other chores. 😉

@compulim compulim added Enhancement community-help-wanted This is a good issue for a contributor to take on and submit a solution Good first bug backlog Out of scope for the current iteration but it will be evaluated in a future release. labels Jan 28, 2019
@sanoorvishwa
Copy link
Author

Thank @neetu-das and @compulim . Both pollingInterval and conversationId are now available in createDirectline.js constructor.

Thanks and closing this issue.

@corinagum corinagum removed backlog Out of scope for the current iteration but it will be evaluated in a future release. needs-repro Waiting for repro or investigation labels Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-help-wanted This is a good issue for a contributor to take on and submit a solution Good first bug
Projects
None yet
Development

No branches or pull requests

3 participants