Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not have persisted padding below transcript #1934

Closed
compulim opened this issue Apr 28, 2019 · 0 comments · Fixed by #1939
Closed

Should not have persisted padding below transcript #1934

compulim opened this issue Apr 28, 2019 · 0 comments · Fixed by #1939
Assignees
@corinagum
Labels
p0 Must Fix. Release-blocker
Projects
4.4 Prioritization

Comments

@compulim
Copy link
Contributor

compulim commented Apr 28, 2019 •
edited
Loading

Repro steps

  1. Navigate to https://microsoft.github.io/BotFramework-WebChat/01.a.getting-started-full-bundle/
  2. Wait until it is connected
  3. Type "carousel" 5 times

Expected: no padding below transcript

Actual:
image

Please add a test to verify the fix is in-place.
@compulim compulim added 4.4 p0 Must Fix. Release-blocker labels Apr 28, 2019
@corinagum corinagum added this to In-Flight in 4.4 Prioritization Apr 29, 2019
@corinagum corinagum mentioned this issue Apr 29, 2019
Merged
@corinagum corinagum moved this from In-Flight to Review in 4.4 Prioritization Apr 29, 2019
@corinagum corinagum moved this from Review to Done in 4.4 Prioritization May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corinagum corinagum

Labels
p0 Must Fix. Release-blocker
Projects
No open projects
4.4 Prioritization
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix vertical spacing of ConnectivityStatus when empty corinagum/BotFramework-WebChat
2 participants
@compulim @corinagum