Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE11 - intermittent gap at the bottom of the transcript above SendBox #1944

Closed
corinagum opened this issue May 1, 2019 · 4 comments
Closed
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner p1 Painful if we don't fix, won't block releasing

Comments

@corinagum
Copy link
Contributor

corinagum commented May 1, 2019

As it turns out, this repros both for adaptive cards and markdown images. This is not isolated to
Repro steps:

  1. Open Mock Bot in IE11
  2. Type help
  3. Press button: 'Show review using Adaptive Card'
  4. Note the big gap on the transcript between the send box and the most recent message, the unordered list.

image

JSON causing this issue:

{
    "type": "AdaptiveCard",
    "body": [
        {
            "type": "ColumnSet",
            "columns": [
                {
                    "type": "Column",
                    "items": [
                        {
                            "type": "TextBlock",
                            "text": "Airports"
                        },
                        {
                            "type": "TextBlock",
                            "spacing": "None",
                            "size": "ExtraLarge",
                            "weight": "Bolder",
                            "text": "Sea-Tac"
                        },
                        {
                            "type": "TextBlock",
                            "spacing": "None",
                            "text": "3 ★★★☆☆ (856) · $$$$",
                            "isSubtle": true
                        },
                        {
                            "type": "TextBlock",
                            "size": "Small",
                            "text": "**Steve G. said** \"Another day, another airport.\"",
                            "wrap": true
                        }
                    ],
                    "width": 2
                },
                {
                    "type": "Column",
                    "items": [
                        {
                            "type": "Image",
                            "url": "https://upload.wikimedia.org/wikipedia/commons/2/23/Deltalax_%28cropped%29.jpg"
                        }
                    ],
                    "width": 1
                }
            ]
        }
    ],
    "actions": [
        {
            "type": "Action.OpenUrl",
            "title": "More Info",
            "url": "https://www.portseattle.org/sea-tac"
        }
    ],
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.0",
    "speak": "three of five stars, 856 reviews, Extremely Expensive. Steve G said, \"Another day, another airport\""
}
@corinagum corinagum added 4.4 bug Indicates an unexpected problem or an unintended behavior. labels May 1, 2019
@corinagum corinagum changed the title IE 11 - intermittent gap at the bottom of the transcript above SendBox IE11 - intermittent gap at the bottom of the transcript above SendBox May 1, 2019
@compulim
Copy link
Contributor

compulim commented May 2, 2019

Shortening the repro:

  • Type help to make sure the screen is filled with content
  • Type card review

The primary problem is AC set max-width to 100% on the ac-image, that's why the image on top-right is squashed.

image

If we set it to a non-percentage value, it will just works.

I am more convinced this is IE11 related layout issues in Adaptive Cards. Will try different previous versions and see if it produce same result.

@corinagum corinagum added 4.5 and removed 4.4 labels May 5, 2019
@cwhitten cwhitten added the p1 Painful if we don't fix, won't block releasing label May 13, 2019
@corinagum corinagum moved this from P1 to To do in R8 Prioritization Jun 10, 2019
@compulim
Copy link
Contributor

This is related to the size of the image and the way AC render the image trigger a bug in IE11. IE11 calculate the height of the container box wrongly.

File an issue to Adaptive Card team, including few things:

  1. Adaptive Card payload (JSON + image) with the problematic card
  2. Repro of the issue outside of Web Chat (to clear our name)
    • You will need to show the "invisible height" of the container box

@corinagum
Copy link
Contributor Author

I have filed a bug with Adaptive Cards, and in the meantime I updated our Mock Bot with a smaller image so that this render error will not occur on Web Chat with Mock Bot. :)

compulim/BotFramework-MockBot#16

@corinagum
Copy link
Contributor Author

I filed the issue with Adaptive Cards here: microsoft/AdaptiveCards#3056

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior. front-burner p1 Painful if we don't fix, won't block releasing
Projects
No open projects
Development

No branches or pull requests

3 participants