Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive card render error in IE11 #2187

Closed
Junlol opened this issue Jul 15, 2019 · 4 comments · Fixed by #2195
Closed

Adaptive card render error in IE11 #2187

Junlol opened this issue Jul 15, 2019 · 4 comments · Fixed by #2195
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. needs-repro Waiting for repro or investigation

Comments

@Junlol
Copy link

Junlol commented Jul 15, 2019

Screenshots

webchat render cards error

Version

webchat 4.5.0
cdn: https://cdn.botframework.com/botframework-webchat/latest/webchat-es5.js

Describe the bug

I am use webchat es5 sample in IE11, then typing help to render cards, but cards not rendered.

webchat es5 sample link

@Junlol Junlol added bug Indicates an unexpected problem or an unintended behavior. Pending labels Jul 15, 2019
@corinagum
Copy link
Contributor

Thanks for reporting this. I am investigating the cause.

@corinagum corinagum added the needs-repro Waiting for repro or investigation label Jul 15, 2019
@corinagum
Copy link
Contributor

corinagum commented Jul 15, 2019

To anyone running into this issue, I have the temporary workaround of using the browser-polyfill from babel@5.6. Just add this to your index.html:

<script src="https://cdnjs.cloudflare.com/ajax/libs/babel-core/5.6.15/browser-polyfill.min.js"></script>

Still investigating the fix.

@corinagum corinagum self-assigned this Jul 15, 2019
@compulim
Copy link
Contributor

We believe the problem is introduced in #1970 (ESLint) and on this line.

The problem is, we moved from:

const firstChildren = element.children[0];

to

const [firstChildren] = element.children;

In IE11, NodeList is not iterable. But in Chrome/Edge, NodeList is iterable.

We should include core-js module that improvise NodeList as iterable. More details can be found on https://github.com/zloirock/core-js#iterable-dom-collections.

@corinagum
Copy link
Contributor

@compulim will be doing a patch to 4.5(.1) shortly, after which this fix will be available in the latest release. Thank you for your patience!

@daveta daveta added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. customer-replied-to Required for internal reporting. Do not delete. labels Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-replied-to Required for internal reporting. Do not delete. customer-reported Required for internal Azure reporting. Do not delete. needs-repro Waiting for repro or investigation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants