Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output build should have correct version number burnt #2524

Closed
compulim opened this issue Oct 31, 2019 · 0 comments · Fixed by #2525
Closed

Output build should have correct version number burnt #2524

compulim opened this issue Oct 31, 2019 · 0 comments · Fixed by #2525
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete.

Comments

@compulim
Copy link
Contributor

Version

master

Describe the bug

For the burnt version number, it appears to be undefined instead of 4.6.0.

In PR #2182, we moved from vulnerable babel-plugin-version-transform to babel-plugin-transform-inline-environment-variables. The environment variable should be in lowercase, npm_package_version, instead of NPM_PACKAGE_VERSION. Thus, the Babel plugin did not pick up and cannot burn it into the source file.

To Reproduce

Steps to reproduce the behavior:

  1. Host Web Chat with one of the daily build
  2. Navigate to the host app
  3. Press F12
  4. In the Elements tab, navigate to html/head/meta and see the burnt version of Web Chat

Expected behavior

It should say 4.6.0 or 4.6.0-... or 0.0.0-0 (for development build).

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels Oct 31, 2019
This was referenced Oct 31, 2019
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix version number to burn correctly under Ubuntu microsoft/BotFramework-WebChat
1 participant
@compulim