Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aria-keyshortcuts should use AltGraph instead of Option #4325

Closed
compulim opened this issue Jun 23, 2022 · 0 comments · Fixed by #4323
Closed

aria-keyshortcuts should use AltGraph instead of Option #4325

compulim opened this issue Jun 23, 2022 · 0 comments · Fixed by #4323
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

compulim commented Jun 23, 2022

Screenshots

Version

main of 4.15.3-0

Describe the bug

According to W3C, aria-keyshortcuts should be "alt+shift+a" or "ctrl+altgraph+a" (for "Ctrl + Option + A" in macOS)

However, when narrating it as accessible name, we do not need + (plus) signs.

Keystroke aria-keyshortcuts Accessible name
Alt + Shift + A "Alt+Shift+a" "Alt Shift A"
Ctrl + Option + A "Ctrl+AltGraph+a" "Ctrl Option A"

Steps to reproduce

  1. Send suggested-actions to the bot
  2. Observe the <button> element of suggested action button

Expected behavior

It should have aria-keyshortcuts of "alt+shift+a".

Additional context

[Bug]

@compulim compulim added the bug Indicates an unexpected problem or an unintended behavior. label Jun 23, 2022
@compulim compulim self-assigned this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant