Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev box: test-harness is CommonJS and should use strip-ansi@^6 #4473

Closed
2 tasks
compulim opened this issue Oct 28, 2022 · 0 comments · Fixed by #4474
Closed
2 tasks

Dev box: test-harness is CommonJS and should use strip-ansi@^6 #4473

compulim opened this issue Oct 28, 2022 · 0 comments · Fixed by #4474
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete.

Comments

@compulim
Copy link
Contributor

Is it an issue related to Adaptive Cards?

  • Yes, this is an Adaptive Card issue but it is specific to Web Chat.

Do you have any screenshots?

No response

What version of Web Chat are you using?

Unrelated

Which distribution are you using Web Chat from?

Unrelated

Which hosting environment does this issue primarily affect?

Others or unrelated

Which browsers and platforms do the issue happened?

No response

Which area does this issue affect?

Others/unrelated

Is this an accessibility issue?

  • Yes, this is an accessibility issue.

Please describe the bug

In #4392, we bumped to strip-ansi@7.0.1.

However, strip-ansi@^7 is ESM only. We should use strip-ansi@^6 until we ported our code to ESM.

Do you see any errors in console log?

No response

How to reproduce the issue?

  1. Run npm run build under /packages/test/harness/

What is the expected and actual behavior?

Expected:
HTML tests should run properly.

Actual:
HTML tests fail because test-harness is not building properly.

Adaptive Card JSON

No response

Additional context

No response

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels Oct 28, 2022
@compulim compulim added this to the release-4.15.5 milestone Oct 29, 2022
@compulim compulim changed the title test-harness is CommonJS and should use strip-ansi@^6 Dev box: test-harness is CommonJS and should use strip-ansi@^6 Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant